Fix global value for Image Class missing from Figure Class in Articles site module#47490
Open
Chitrakshi180706 wants to merge 2 commits intojoomla:6.1-devfrom
Open
Conversation
…s site module When 'Use Global' is selected for Image Class, the value was not being applied to the figure tag because the code was using the literal string 'Use Global' instead of fetching the actual global value. Fixes joomla#47335
Chitrakshi180706
requested review from
HLeithner,
Hackwar,
bembelimen,
chmst,
laoneo and
rdeutz
as code owners
Contributor
|
Your branch is 6.1 but you are trying to merge it into 5.4 And you must complete the ai check confirmation |
Author
|
Thank you for the feedback @brianteeman! I have updated the base branch to 6.1-dev and confirmed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves #47335 .
Summary of Changes
When 'Use Global' is selected for Image Class in the Articles
module, the global value was not being applied to the figure tag.
The code was checking if float_intro was empty, but 'Use Global'
is not empty — it's a literal string. Fixed by also checking if
the value equals 'Use Global' and fetching the actual global
value in that case.
Testing Instructions
Actual result BEFORE applying this Pull Request
(global image class missing)Expected result AFTER applying this Pull Request
(global image class applied correctly)Link to documentations
Please select:
Documentation link for guide.joomla.org:
[✅] No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
[✅] No documentation changes for manual.joomla.org needed