Add media playback enhancements: subtitle format expansion + audio track selection#14
Merged
Merged
Conversation
…ack selection - Expand subtitle support: add .vtt, .ass, .ssa formats (in addition to .srt) - Support 2-3 letter ISO 639 language codes - Unify duplicated directory scan logic into findSubtitleConfigs() helper - Add audio track selection UI: shows dropdown only for multi-audio files - Audio track selection via language preference (for language-tagged tracks) - Tests: update PlayerScreenTest for new formats, move to androidTest for Uri mocking - All unit tests pass (22), all instrumented tests pass (67 on both emulators) - Lint clean, app builds and runs successfully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive media playback enhancements to SimpleTorrent:
findSubtitleConfigs()helperTest Plan
✅ Phone portrait and landscape orientations
✅ Tablet form factor with adaptive layout
✅ Foldable device (unfolded) with proper UI adaptation
✅ All unit tests pass (22 tests)
✅ All instrumented tests pass (67 on both emulators)
✅ Lint checks clean
✅ App builds and runs successfully
Testing Results
Verified media playback feature works correctly across: