fix --compare crash on functions missing from the second profile#115
Open
nvxbug wants to merge 1 commit into
Open
fix --compare crash on functions missing from the second profile#115nvxbug wants to merge 1 commit into
nvxbug wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 84.98% 86.02% +1.04%
==========================================
Files 1 1
Lines 2337 2340 +3
==========================================
+ Hits 1986 2013 +27
+ Misses 351 327 -24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
graphs_compare binds function2 only inside the try branch that runs when function1 is also present in the second profile. When a function exists only in the first profile the except branch runs and never sets function2, so the calls2 comprehension further down reads a stale function2 left from an earlier iteration, or raises UnboundLocalError on the first function processed. Comparing two profiles whose function sets differ is the ordinary case for --compare, so this fires on normal runs rather than crafted input.
Reset function2 to None at the top of each iteration and use an empty calls2 when there is no match. An unmatched function's edges then fall through to the same single-value labels its own node already gets, instead of borrowing another function's call data. Keeping the fallback next to the comprehension leaves the edge loop reading a consistent map.