Skip to content

fix --compare crash on functions missing from the second profile#115

Open
nvxbug wants to merge 1 commit into
jrfonseca:mainfrom
nvxbug:compare-missing-function
Open

fix --compare crash on functions missing from the second profile#115
nvxbug wants to merge 1 commit into
jrfonseca:mainfrom
nvxbug:compare-missing-function

Conversation

@nvxbug

@nvxbug nvxbug commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

graphs_compare binds function2 only inside the try branch that runs when function1 is also present in the second profile. When a function exists only in the first profile the except branch runs and never sets function2, so the calls2 comprehension further down reads a stale function2 left from an earlier iteration, or raises UnboundLocalError on the first function processed. Comparing two profiles whose function sets differ is the ordinary case for --compare, so this fires on normal runs rather than crafted input.

Reset function2 to None at the top of each iteration and use an empty calls2 when there is no match. An unmatched function's edges then fall through to the same single-value labels its own node already gets, instead of borrowing another function's call data. Keeping the fallback next to the comprehension leaves the edge loop reading a consistent map.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.02%. Comparing base (d1ba70a) to head (1b29536).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   84.98%   86.02%   +1.04%     
==========================================
  Files           1        1              
  Lines        2337     2340       +3     
==========================================
+ Hits         1986     2013      +27     
+ Misses        351      327      -24     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant