Fix integer overflow in hash_old#218
Merged
Merged
Conversation
Member
|
@MariuszCwikla The PR looks fine but the test should either be added to spec/ruby or test/jruby. The tests under test/mri are copied from CRuby and we do not edit them in our repo. Thanks for the PR! |
Contributor
Author
|
@headius thanks for hints but it seems that jruby-openssl is not consistent jruby repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #216
X509Name.hashwas fixed and old implementation renamed tohash_oldHowever I discovered that old method still wasn't working correclty due to integer overflow:
Ruby is using
unsinged intfor this calculation. In JRuby changing int to long solves the issue.