switch to pytest.raises to ensure that assertions are raised and not silently passing

Author: jonathanrcross

tests/test_base.py

@@ -54,7 +54,7 @@ def test_base_delete_connection_error():
 def test_base_raise_exception_not_requests_response_object(mock_requests):
     mock_requests().delete.side_effect = [requests.RequestException()]
 
-    try:
+    with pytest.raises(nomad.api.exceptions.BaseNomadException) as excinfo:
         n = nomad.Nomad(
             host="162.16.10.102",
             port=common.NOMAD_PORT,
@@ -64,19 +64,24 @@ def test_base_raise_exception_not_requests_response_object(mock_requests):
 
         _ = n.job.deregister_job("example")
 
-    except nomad.api.exceptions.BaseNomadException as err:
-        assert hasattr(err, "text") is False
-        assert isinstance(err.nomad_resp, requests.RequestException)
-        assert "raised due" in str(err)
+    # excinfo is a ExceptionInfo instance, which is a wrapper around the actual exception raised.
+    # The main attributes of interest are .type, .value and .traceback.
+    # https://docs.pytest.org/en/3.0.1/assert.html#assertions-about-expected-exceptions
+    assert hasattr(excinfo.value.nomad_resp, "text") is False
+    assert isinstance(excinfo.value.nomad_resp, requests.RequestException)
+    assert "raised due" in str(excinfo)
 
 
 def test_base_raise_exception_is_requests_response_object(nomad_setup):
-    try:
-        _ = nomad_setup.job.deregister_job("example")
-    except nomad.api.exceptions.BaseNomadException as err:
-        assert hasattr(err, "text") is True
-        assert isinstance(err.nomad_resp, requests.Response)
-        assert "raised with" in str(err)
+    with pytest.raises(nomad.api.exceptions.BaseNomadException) as excinfo:
+        _ = nomad_setup.job.get_job("examplezz")
+
+    # excinfo is a ExceptionInfo instance, which is a wrapper around the actual exception raised.
+    # The main attributes of interest are .type, .value and .traceback.
+    # https://docs.pytest.org/en/3.0.1/assert.html#assertions-about-expected-exceptions
+    assert hasattr(excinfo.value.nomad_resp, "text") is True
+    assert isinstance(excinfo.value.nomad_resp, requests.Response)
+    assert "raised with" in str(excinfo)
 
 
 @pytest.mark.skipif(tuple(int(i) for i in os.environ.get("NOMAD_VERSION").split(".")) < (0, 7, 0), reason="Nomad dispatch not supported")