fix(types): tighten parseCookie return type#287
Open
Hashim1999164 wants to merge 1 commit into
Open
Conversation
Hashim1999164
force-pushed
the
fix/parse-cookie-types
branch
from
July 26, 2026 19:36
70ecc88 to
c7fda13
Compare
Hashim1999164
force-pushed
the
fix/parse-cookie-types
branch
2 times, most recently
from
July 26, 2026 19:37
362910c to
6dbfabb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseCookiegeneric over thedecodeoption so the return type mirrors the decoder.Record<string, string>instead ofRecord<string, string | undefined>.undefined(or other types) keep accurate typing via generics.stringifyCookiestill acceptsundefinedvalues so existing skip behavior is unchanged.Fixes #252
Test plan
npm test(tsc, prettier, vitest, size-limit)expectTypeOfchecks for default and custom decode return types