Skip to content

(fix) Install modules where one module name is a substring of the other#5

Open
noodle wants to merge 1 commit into
jstty:dev/v1.0from
noodle:dev2/v1.0
Open

(fix) Install modules where one module name is a substring of the other#5
noodle wants to merge 1 commit into
jstty:dev/v1.0from
noodle:dev2/v1.0

Conversation

@noodle

@noodle noodle commented Apr 7, 2017

Copy link
Copy Markdown
Contributor

Modules don't install or clean up correctly when a !== b but a.indexOf(b) === 0

e.g. when a = 'lodash' and b = 'lod'

ya.add(['lod', 'lodash']);
yield ya.install();

var lod = ya.get('lod'); // correct
var lodash = ya.get('lodash'); // null

Modules don't install or clean up correctly when `a !== b` but `a.indexOf(b) === 0`

e.g. when `a = 'lodash'` and `b = 'lod'`
```js
ya.add(['lod', 'lodash']);
yield ya.install();

var lod = ya.get('lod'); // correct
var lodash = ya.get('lodash'); // null
```
@coveralls

coveralls commented Apr 7, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 92.419% when pulling 906ef4a on noodle:dev2/v1.0 into 2ff93a3 on jstty:dev/v1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants