Replace hard-coded lookup table with on-the-fly version detection#806
Open
sormuras wants to merge 1 commit into
Open
Replace hard-coded lookup table with on-the-fly version detection#806sormuras wants to merge 1 commit into
sormuras wants to merge 1 commit into
Conversation
Member
Author
|
This block of junit-examples/junit-modular-world/src/build/Project.java Lines 46 to 63 in 30d2f97 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Prior to this change, a hard-coded lookup table mapping module names to download URIs was used to resolve the
org.junit.startmodule and all other required modules injunit-source-launcher/lib/DownloadRequiredModules.java.This change makes use of https://github.com/raphw/jenesis-modules#jenesis-module-repository to resolve modular JAR files via their
name@versioncoordinates; still backed by Maven Central.Note that
org.jspecifyneeds a pin to its1.0.0version due to lack a compiled version in their module descriptor. Find more details here:Also note that when a new version of JUnit is released, the index at https://github.com/raphw/jenesis-modules needs to be updated to include the version of JUnit - in order to support it in the
junit-source-launcher/lib/DownloadRequiredModules.javaprogram.I hereby agree to the terms of the JUnit Contributor License Agreement.