Fix broken homepage mobile layout by preventing horizontal overflow#839
Open
ritorhymes wants to merge 1 commit intojupyter:mainfrom
Open
Fix broken homepage mobile layout by preventing horizontal overflow#839ritorhymes wants to merge 1 commit intojupyter:mainfrom
ritorhymes wants to merge 1 commit intojupyter:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the homepage, the Notebook feature section overflows horizontally at certain viewport widths between
421pxand991px, creating page-wide horizontal scrolling that breaks the page layout and compresses text into very narrow columns (sometimes just 1–2 words per line) that are difficult to read. This fix contains overflow in that range by wrapping feature cards into a two-column layout while preserving existing behavior below421pxand at992px+.Why this approach?
<=420pxbehaviors which would collapse the layout earlier than intended and introduce unnecessary whitespace.What changed:
@media (min-width: 421px) and (max-width: 991px)in_sass/components/_homepage.scssfor.homepage-section .featurelistto enable wrapping..featurecards in that same range to fit two per row (width: 50%) with controlled spacing (margin,padding) andbox-sizing: border-boxto prevent overflow.<=420pxstacks vertically) and desktop behavior (>=992px) intact.Before and After Screenshots
Mobile captures from a device with an approximately 450px viewport width
Before
Notice text content collapsing to 1-2 words per line, and the image underneath the feature section has empty whitespace to the right of it indicating page overflow

After
Notice all columns fit more than 2 words per line and the image under the feature section now has margins equal to the rest of the page indicating no page overflow*
