Bugfix / Correct stopping async cell execution#1069
Open
truongle1501 wants to merge 3 commits intojupyter:mainfrom
Open
Bugfix / Correct stopping async cell execution#1069truongle1501 wants to merge 3 commits intojupyter:mainfrom
truongle1501 wants to merge 3 commits intojupyter:mainfrom
Conversation
…art kernel and run all cells
e653e61 to
e40d44e
Compare
for more information, see https://pre-commit.ci
minrk
reviewed
Oct 15, 2025
| and msg["content"]["execution_state"] == "idle" | ||
| ): | ||
| break | ||
| if msg["header"]["msg_type"] == "status": |
Member
There was a problem hiding this comment.
Thanks! I see that this fixes a status message from a previous cell.
Rather than waiting for busy and then idle, which would have a similar issue, just a bit farther back in time, I think the fix might be to add a check for and msg["parent_header"].get("msg_id") == msg_id to make sure we are stopping on the idle message from this request, rather than any idle message.
Member
|
Care to rebase this one to get the CI kicked off again fresh? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding document:
jupyter_client/docs/messaging.rst
Lines 1634 to 1639 in eb96748
Context:
The async cell execution stopped too early because it hit the below condition while the cell is being executed. This also means there was a moment when iopub message satisfied both
msg["parent_header"].get("msg_id") == msg_idandexecution_state='idle'jupyter_client/jupyter_client/client.py
Lines 560 to 572 in eb96748
This PR aims to set a flag to allow stopping the cell execution only when it saw 'busy' state, which forces the stop condition to run after cell execution starts.