Add Kernel Lifecycle State Management Mixin#1074
Open
Zsailer wants to merge 2 commits intojupyter:mainfrom
Open
Add Kernel Lifecycle State Management Mixin#1074Zsailer wants to merge 2 commits intojupyter:mainfrom
Zsailer wants to merge 2 commits intojupyter:mainfrom
Conversation
Introduces a comprehensive state machine implementation for tracking kernel lifecycle states during management operations. Key features: - KernelManagerStateMixin for automatic state tracking via method wrapping - LifecycleState string-based enum for clean API usage - state_transition decorator for custom state management scenarios - Automatic error handling with state reset to UNKNOWN on failures - Support for both sync and async kernel operations - Non-intrusive mixin design compatible with existing kernel managers States tracked: UNKNOWN, STARTING, STARTED, RESTARTING, RESTARTED, TERMINATING, DEAD with automatic transitions during start/restart/shutdown operations.
for more information, see https://pre-commit.ci
Member
|
Want to rebase this PR now to see if all the tests can pass, now that we've cleaned up CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #763.
This PR introduces a state machine for tracking kernel lifecycle states using a mixin approach that can be easily adopted by any existing kernel manager implementation.
The
KernelManagerStateMixindesign allows developers to add state tracking to any existing kernelmanager by simply including it in the inheritance chain - no configuration or code changes required.
This opt-in approach means:
I intentionally did not add this to the default kernel managers yet, allowing the community to
evaluate the approach first.
Usage