Open
Conversation
Member
|
Hmm, I'm not able to reproduce this unfortunately. Do you know why the path is starting with a But I agree if this is possible we should check that the path is relative rather than absolute. However, we haven't quite yet dropped support for Python 2 (happening very soon though). Would you mind writing this without pathlib so that the python 2 tests will still pass? |
|
I am having the same issue. The Steps to replicate:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the validate button is failing for me on current master with error messages like:
this is because path is being set with '/' as the first character, making the os.path.join with the notebook_dir a noop. My fix using pathlib.relative_to works, but obviously it would be better to catch this at the initialization and make sure path is relative.