Use NPM packages instead of bower for formgrader extension dependencies#1967
Use NPM packages instead of bower for formgrader extension dependencies#1967brichet merged 4 commits intojupyter:mainfrom
Conversation
| nbgrader/server_extensions/formgrader/static/node_modules/autosize/example | ||
| nbgrader/server_extensions/formgrader/static/node_modules/autosize/src | ||
| nbgrader/server_extensions/formgrader/static/node_modules/bootstrap/less | ||
| nbgrader/server_extensions/formgrader/static/node_modules/bootstrap/js | ||
| nbgrader/server_extensions/formgrader/static/node_modules/bootstrap/grunt | ||
| nbgrader/server_extensions/formgrader/static/node_modules/jquery/external | ||
| nbgrader/server_extensions/formgrader/static/node_modules/jquery/src | ||
| nbgrader/server_extensions/formgrader/static/node_modules/underscore/amd | ||
| nbgrader/server_extensions/formgrader/static/node_modules/underscore/cjs | ||
| nbgrader/server_extensions/formgrader/static/node_modules/underscore/modules | ||
| nbgrader/server_extensions/formgrader/static/node_modules/underscore/underscore-esm* | ||
| nbgrader/server_extensions/formgrader/static/node_modules/underscore/underscore-node* | ||
| nbgrader/server_extensions/formgrader/static/node_modules/underscore/underscore-umd* |
There was a problem hiding this comment.
Because we're using the exceptions below, we can replace all of these specific rules with a more general one:
nbgrader/server_extensions/formgrader/static/node_modules/**/*
I think this would make maintenance a tiny bit easier moving forward.
There was a problem hiding this comment.
I think it would be quite similar, we would have to specify which files we want to keep instead of specifying which files we want to remove.
We probably want to keep package.json files, readme and some other files to know the version fetched.
The exceptions below are to prevent the following to remove these directories:
Line 13 in ab7ef18
There was a problem hiding this comment.
Ah, I see what you mean. I think the change I want to see goes well beyond the scope of this PR. Thanks for clarifying.
|
Let's merge this one as it fixes some deprecated dependencies. |
Fixes #1966
Should fix https://github.com/jupyter/nbgrader/security/dependabot/60
This PR replaces the use of deprecated
bowerby NPM.It also updates
underscoredependency to >=1.13.1, which should fix a security error.