refactor: reduce reliance on regex in path handling#1968
Draft
shreve wants to merge 15 commits intojupyter:mainfrom
Draft
refactor: reduce reliance on regex in path handling#1968shreve wants to merge 15 commits intojupyter:mainfrom
shreve wants to merge 15 commits intojupyter:mainfrom
Conversation
Contributor
|
|
This change tries to modernize the way we handle paths in nbgrader by using pathlib.Path and centralizing logic for searching and extracting information from paths into CourseDirectory. By using `Path(root).glob(pat)` instead of `glob.glob(root / pat)`, we can avoid some issues of needing to escape CourseDirectory.root because the glob will be scoped underneath a fixed path. Introduces a new `CourseDirectory.find_assignments` method to help locate assignment directories across steps and students. Fixes jupyter#1965
shreve
force-pushed
the
safer-paths
branch
4 times, most recently
from
366ae5b to
e538517
Compare
The test formerly relied on a normal directory being missing. This commit uses /dev/null as the exchange directory to ensure it will always be missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change tries to modernize the way we handle paths in nbgrader by using pathlib.Path and centralizing logic for searching and extracting information from paths into CourseDirectory.
By using
Path(root).glob(pat)instead ofglob.glob(root / pat), we can avoid some issues of needing to escape CourseDirectory.root because the glob will be scoped underneath a fixed path.Introduces a new
CourseDirectory.find_assignmentsmethod to help locate assignment directories across steps and students.Fixes #1965