Fixed issue when opening notebook with %20 in filename#7848
Open
og-khushalpatel wants to merge 8 commits intojupyter:mainfrom
Open
Fixed issue when opening notebook with %20 in filename#7848og-khushalpatel wants to merge 8 commits intojupyter:mainfrom
og-khushalpatel wants to merge 8 commits intojupyter:mainfrom
Conversation
…ollapser (jupyter#7393) Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
SHA256 hashes: jupyter-notebook-application-7.2.1.tgz: 9f0135d2aeb68a39eef25862ce37d266be1a0cbd925398a9588373f89c3433f2 jupyter-notebook-application-extension-7.2.1.tgz: 2107ff3fe36575115a1c02ab87d785dbe5098be5ba8ab777752b2ba8f5e9d5b6 jupyter-notebook-console-extension-7.2.1.tgz: a6fe4ea13819f3a2fcf66e6a51adb43c858c2a2c18ec373a263c51fa2a04a152 jupyter-notebook-docmanager-extension-7.2.1.tgz: d73cd4e7c9d353950ef6b48630a66879ceadb38635beae52f439c639ad43e47f jupyter-notebook-documentsearch-extension-7.2.1.tgz: 34db4119e03d9fecda82da4243fa8bb743d9a39553de6322b2a85abd194525a2 jupyter-notebook-help-extension-7.2.1.tgz: 98cae5e7a461965f87602f88545c2032fbe866210b36f3f94eb09416fbb9469d jupyter-notebook-lab-extension-7.2.1.tgz: 1c32795ed3436c58c7d6c4870d04d76f4425f499a42403846ebe6d1da0e08e70 jupyter-notebook-notebook-extension-7.2.1.tgz: 95264861e77518304befdda4ab392e7858fff3c261943b35d1b17a5101ebf81a jupyter-notebook-terminal-extension-7.2.1.tgz: 1609c3fa9df25461081c0718d564f843eb828a197bf95c850286fca74abd236d jupyter-notebook-tree-7.2.1.tgz: c8e10cb9e43178a5f1b32e98198d564aef71b20a2b0bf9fa9635c0a92775fc42 jupyter-notebook-tree-extension-7.2.1.tgz: 3d57a98b515643d73664df2455695cd6fef4877a59170deae9caeffa68a29398 jupyter-notebook-ui-components-7.2.1.tgz: ffb0c8fb0a54625114c3852f18af209c91c472eb16df3b02a5949caa2d70d76a notebook-7.2.1-py3-none-any.whl: f45489a3995746f2195a137e0773e2130960b51c9ac3ce257dbc2705aab3a6ca notebook-7.2.1.tar.gz: 4287b6da59740b32173d01d641f763d292f49c30e7a51b89c46ba8473126341e
* Upgrade JupyterLab dependencies to v4.2.5 * Bump `@jupyterlab/testutils` * Upgrade the lock file
SHA256 hashes: jupyter-notebook-application-7.2.2.tgz: 84fcdee5e83846ed7d5d475ae10c4c19e7489e0fdb9e963fa0049d9492d99897 jupyter-notebook-application-extension-7.2.2.tgz: 767e71a704fd1e10277dcde12e9d6c9bb8f7d4ae2aa16cd94edae1a4130c0582 jupyter-notebook-console-extension-7.2.2.tgz: 68c711442d96c20f3e9e3fe998356e184f41bf13cd8657290a37240326cbae96 jupyter-notebook-docmanager-extension-7.2.2.tgz: efc896dd4fd8b19624bb29eb7516aa392abdeaaf2a47d83c568667f4810d2922 jupyter-notebook-documentsearch-extension-7.2.2.tgz: cf9db634d3644c62ec228c6bec45bb5e4cbbf3d94544c0c6c0038bd4324a4b8f jupyter-notebook-help-extension-7.2.2.tgz: df8e5f77211fef32744660fb24237d223fa2fa64a98654e611eda681d3c4828d jupyter-notebook-lab-extension-7.2.2.tgz: 8fadd04c3ee3b81a742c6b396cc86dc598aa5e1da81e4820ab5f04a8c0838008 jupyter-notebook-notebook-extension-7.2.2.tgz: ea156bbab9c3a4743d30171511adc0b4a15da3dfe311513d44760a7bfd1e7246 jupyter-notebook-terminal-extension-7.2.2.tgz: b2c8a681880922ef513ab4761688fcb4a236c3264cd7ccb5d442e33044a9d782 jupyter-notebook-tree-7.2.2.tgz: 09b5dc5f97f9bc5a0d01b73fe9afee4404f8ce125dd9fcb1e7b33ebb73287fa3 jupyter-notebook-tree-extension-7.2.2.tgz: 4e59dca1f172a5a68c0ef2128713173f9bc4f51f9f00c4cb129d09d7a1f548d3 jupyter-notebook-ui-components-7.2.2.tgz: e1ae95daa9258804e06d26dc7d48f9c1ecc4c110f30591a6c116a48e315bff7d notebook-7.2.2-py3-none-any.whl: c89264081f671bc02eec0ed470a627ed791b9156cad9285226b31611d3e9fe1c notebook-7.2.2.tar.gz: 2ef07d4220421623ad3fe88118d687bc0450055570cdd160814a59cf3a1c516e
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
SHA256 hashes: jupyter-notebook-application-7.2.3.tgz: cce3dce263ea224b51a1638e7282b5a3baca6f735d93aca906f3b8913fcb0590 jupyter-notebook-application-extension-7.2.3.tgz: ae998be2233395775ded463fc71ebac755f1794c5af2cbfdccf067b2abc33e45 jupyter-notebook-console-extension-7.2.3.tgz: c1ae6cbec8da1ad8721f1b8b0b7fe097e4f2ff5453a552697b3e2b158be15f69 jupyter-notebook-docmanager-extension-7.2.3.tgz: cda78f928e4f5f5495fde0f52ea17cb0e1ca2acd32cfcd0454adcf17bb69d4b1 jupyter-notebook-documentsearch-extension-7.2.3.tgz: 1e18bb83fe194706815f33b2d257ac1462bb9ee58bb34a9529c51dd7643f5e36 jupyter-notebook-help-extension-7.2.3.tgz: 0c8f2814b17ef741368ba23577c2941170eed27df3362250d71f8ad6c2329c7b jupyter-notebook-lab-extension-7.2.3.tgz: c57d34bf7f19c76640672f36fa768fa14cd0cf5f33fc92e195b202723f60118b jupyter-notebook-notebook-extension-7.2.3.tgz: f46425035a7e60528fc9752a58405df535e4d3910a7a5ce7b994e09017087730 jupyter-notebook-terminal-extension-7.2.3.tgz: fc5d3c8c98925f7a9c94029e9821e5a6588ab05a2100268a7b5f8692c37e40d4 jupyter-notebook-tree-7.2.3.tgz: 23fee3abde92b0884eb02f46d41e69ff2f091fe81df93ac8bc5418d09e9afca9 jupyter-notebook-tree-extension-7.2.3.tgz: ce62809858583ac277f38f7d8596059f8e05ebbdd81720a3229bbce5680843a5 jupyter-notebook-ui-components-7.2.3.tgz: e1f9765b2d2fb1282bb27c57f3fccbb7ab6430d4b455bfe74570d234d3d977f7 notebook-7.2.3-py3-none-any.whl: 6e560b360fc805c88037d5d988ed000347b2200f594c6d0929467c25cd11a79b notebook-7.2.3.tar.gz: 3bf03e92f97f0f28bfd3faabe19bdb7fde0c53a58adac78f0b61b1334a53f7a1
Contributor
|
|
Author
|
Hi @krassowski @jtpio , I’m following up on this PR in case it got buried. Please let me know if any changes are needed from my side. Thank you! |
Member
|
@og-khushalpatel looks like this was already fixed in #7698 and available in the latest releases. Can you double check if it works as expected with the latest 7.6 pre-releases or 7.5.5 release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #7823
Code changes
The fix wraps path with
URLExt.encodeParts()inpathopener.tsbefore passing it toURLExt.join(). Previously, paths containing special characters like literal%20(a filename actually named A%20B.ipynb) were passed unencoded, causing the URL constructor to misinterpret%20as an already-encoded space.URLExt.encodeParts()properly percent-encodes each path segment, so%20in a filename becomes%2520in the URL, preserving the literal characters.User-facing changes
Screencast.from.2026-03-04.11-49-26.webm