Skip to content

Family mismatch on dual stack environments breaks whitelist#56

Open
TomCan wants to merge 1 commit into
jvdmr:mainfrom
TomCan:ipv6
Open

Family mismatch on dual stack environments breaks whitelist#56
TomCan wants to merge 1 commit into
jvdmr:mainfrom
TomCan:ipv6

Conversation

@TomCan
Copy link
Copy Markdown

@TomCan TomCan commented Oct 24, 2025

In dual stack environments, r->useragent_addr might return an IPv4 mapped IPv6 address instead of a regular IPv4 address. In that case, apr_sockaddr_t->family will return AF_INET6 instead of AF_INET and will not take any IPv4 entries on the whitelist into account. This can results in whitelisted IPv4 address to be blocked anyway.

This PR solves this by adding additional checks to see if this is in fact an IPv4 mapped IPv6 address, and adjusts the matching logic accordingly.

@lumin-etherlight
Copy link
Copy Markdown

We've been hitting this elusive issue in production for a few weeks. Our duel-stack IPv4/IPv6 server blocking our own whitelisted IPv4 addresses. We've replicated the issue in a controlled environment. I came across this pull-request, reviewed and applied the patch to our builds of mod_evasive, and tested it against our replication process: Our IPv4 addresses are no longer blocked, and mod_evasive works normally for us now. We will watch closely over the next few weeks, and will report here if the patch gives us any issues, but for now things seem to be good.

Thank you @TomCan for the patch :)

@adamboutcher
Copy link
Copy Markdown

Life saver...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants