Family mismatch on dual stack environments breaks whitelist#56
Open
TomCan wants to merge 1 commit into
Open
Conversation
|
We've been hitting this elusive issue in production for a few weeks. Our duel-stack IPv4/IPv6 server blocking our own whitelisted IPv4 addresses. We've replicated the issue in a controlled environment. I came across this pull-request, reviewed and applied the patch to our builds of mod_evasive, and tested it against our replication process: Our IPv4 addresses are no longer blocked, and mod_evasive works normally for us now. We will watch closely over the next few weeks, and will report here if the patch gives us any issues, but for now things seem to be good. Thank you @TomCan for the patch :) |
|
Life saver... |
cgzones
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dual stack environments, r->useragent_addr might return an IPv4 mapped IPv6 address instead of a regular IPv4 address. In that case, apr_sockaddr_t->family will return AF_INET6 instead of AF_INET and will not take any IPv4 entries on the whitelist into account. This can results in whitelisted IPv4 address to be blocked anyway.
This PR solves this by adding additional checks to see if this is in fact an IPv4 mapped IPv6 address, and adjusts the matching logic accordingly.