fix: normalize event payloads across iOS and Android#226
Open
fix: normalize event payloads across iOS and Android#226
Conversation
Add missing event properties to achieve parity between platforms: - onRateChanged: Android now includes `at` (playback position) - onPlayerError: iOS now includes `description` - onPlayerWarning: iOS now includes `code` - onPlayerAdError: iOS now includes `code` - onCasting: iOS now sends `device`, `active`, `available` (was empty) Update TypeScript types: - Add `index` to PlaylistItemEventProps - Add `tracks` array to CaptionsListEventProps (deprecate flat fields) - Add CaptionTrack, CastingEventProps, and other missing interfaces - Add iOS-only events to PropsType with @platform annotations - Add casting event types for iOS-specific granular cast events No breaking changes — all additions are new optional fields or properties. Refs #225
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onRateChanged(Android addsat),onPlayerError/onPlayerWarning/onPlayerAdError(iOS addscode/description),onCasting(iOS now sendsdevice/active/available)indextoPlaylistItemEventProps, addtracksarray toCaptionsListEventProps, add interfaces andPropsTypeentries for iOS-only events (casting, idle, visible, screen tap, buffer, size change)Refs #225
Test plan
onRateChangedincludesaton AndroidonPlayerErrorincludesdescriptionon iOSonPlayerWarningincludescodeon iOSonPlayerAdErrorincludescodeon iOSonCastingincludesdevice/active/availableon iOS