TECH-16: WIP - visual regression tests with backstop JS#87
Open
enotick wants to merge 3 commits into
Open
Conversation
Author
|
@RobLoach @mikemccaffrey I got it working - more details in the Jira issue. |
RobLoach
requested changes
May 29, 2020
RobLoach
left a comment
There was a problem hiding this comment.
Looks great! If you add some documentation with some instruction on how to get it up and running, and where to check tests, that would help the rest of the team get on board.
Co-authored-by: Rob Loach <robloach@gmail.com>
Author
@RobLoach more details with how to run is in the issue - but I'll also work on the documentation we can put into the wiki :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mikemccaffrey @RobLoach I made a first attempt to integrate backstop.js into the circle. I need some help on:
My idea:
we only run test workflow when we merge / push to a branch visual - since we don't need to run it all the time on every deploy
I am not sure how to best test these changes perhaps the best would be try it on one of the projects and see if there are any problems. I took the config that was advised on Pantheon community forum. https://discuss.pantheon.io/t/backstopjs-with-our-pantheon-circleci-orb/386/6