Skip to content

TECH-16: WIP - visual regression tests with backstop JS#87

Open
enotick wants to merge 3 commits into
masterfrom
regression-tests
Open

TECH-16: WIP - visual regression tests with backstop JS#87
enotick wants to merge 3 commits into
masterfrom
regression-tests

Conversation

@enotick
Copy link
Copy Markdown

@enotick enotick commented May 25, 2020

@mikemccaffrey @RobLoach I made a first attempt to integrate backstop.js into the circle. I need some help on:

  • testing strategy for this PR
  • verification on implementation
  • test scenarios (for now only homepage)

My idea:
we only run test workflow when we merge / push to a branch visual - since we don't need to run it all the time on every deploy

I am not sure how to best test these changes perhaps the best would be try it on one of the projects and see if there are any problems. I took the config that was advised on Pantheon community forum. https://discuss.pantheon.io/t/backstopjs-with-our-pantheon-circleci-orb/386/6

@enotick enotick requested review from RobLoach and mikemccaffrey May 25, 2020 15:29
@enotick enotick marked this pull request as ready for review May 29, 2020 15:32
@enotick
Copy link
Copy Markdown
Author

enotick commented May 29, 2020

@RobLoach @mikemccaffrey I got it working - more details in the Jira issue.

Copy link
Copy Markdown

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! If you add some documentation with some instruction on how to get it up and running, and where to check tests, that would help the rest of the team get on board.

Comment thread .circleci/config.yml Outdated
Co-authored-by: Rob Loach <robloach@gmail.com>
@enotick
Copy link
Copy Markdown
Author

enotick commented May 29, 2020

Looks great! If you add some documentation with some instruction on how to get it up and running, and where to check tests, that would help the rest of the team get on board.

@RobLoach more details with how to run is in the issue - but I'll also work on the documentation we can put into the wiki :)

@enotick enotick requested a review from RobLoach May 29, 2020 15:43
@RobLoach RobLoach removed their assignment Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants