Skip to content

Fix save_reactable error in R4.3.1 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcomputing wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix save_reactable error in R4.3.1 #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: reactablefmtr
Type: Package
Title: Streamlined Table Styling and Formatting for Reactable
Version: 2.1.0
Version: 2.1.1
Authors@R: c(
person("Kyle", "Cuilla", role = c("aut", "cre", "cph"), email = "kyle.cuilla@gmail.com"),
person("Greg", "Lin", role = c("ctb")),
Expand Down
2 changes: 1 addition & 1 deletion R/save_reactable.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ save_reactable <- function(input,

message("html file saved to ", getwd(), "/", output)

} else if (tools::file_ext(output) == "png" && tools::file_ext(input) != "Rmd" && tools::file_ext(input) != "html") {
} else if (tools::file_ext(output) == "png" && all(tools::file_ext(input) != "Rmd") && all(tools::file_ext(input) != "html")) {

temp_html <- tempfile(
pattern = tools::file_path_sans_ext(basename(output)),
Expand Down