fix(ci): drop unused deployments:write permission from deploy job#99
Merged
Conversation
Scorecard Token-Permissions (code-scanning alert #15) flagged the deploy job's job-level `deployments: write`. No step uses GitHub's Deployments API — the `environment: production` record is created by GitHub itself, and wrangler-action deploys to Cloudflare Pages without touching it. The remaining id-token/attestations writes are required by attest-build-provenance.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves code-scanning alert #15 (Scorecard Token-Permissions, severity high, score 9/10).
The
deployjob declareddeployments: writeat the job level, but no step uses GitHub's Deployments API:environment: productiondeployment record is created by GitHub's own internal mechanism — it does not consume the job token'sdeploymentsscope.cloudflare/wrangler-actiondeploys to Cloudflare Pages, which never touches GitHub Deployments.The remaining writes are required and retained:
id-token: write— OIDC foractions/attest-build-provenance(Sigstore)attestations: write— writing the build attestationThis is a pre-existing finding (present since the initial commit), not introduced by the recent dependency batch. Removing the dead permission tightens the deploy token and clears the alert. If a deploy ever genuinely needed it, the step would fail with a clear 403 and it's a one-line re-add.