fix: TwitterExtractor hardcoded English aria-label breaks reply extraction for non-English UIs#290
Open
mvanhorn wants to merge 1 commit into
Conversation
…ction for non-English UIs Fixes kepano#272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TwitterExtractorselected the reply count node by matchingaria-label*="Reply", which only matches the English UI. On non-English X / Twitter UIs the aria-label is localized, so reply extraction silently returned 0.Why this matters
Reporter pinpointed the exact aria-label match. The fix swaps the localized aria-label lookup for a
data-testidlookup that X uses consistently across locales.Changes
src/extractors/twitter.ts- select reply count via[data-testid="reply"]instead of[aria-label*="Reply"].Fixes #272