fix: author/date byline heuristic matches day-of-week as a date#291
Merged
kepano merged 2 commits intoJun 6, 2026
Merged
Conversation
The author/date byline regex matched bare weekday names ('Tuesday',
'Wed') as date candidates and stripped them. Restrict the day-of-week
match so weekday-only strings without a numeric date next to them
are not treated as dates.
Fixes kepano#233
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The byline-detection heuristic in
content-patterns.tstreated bare weekday names ("Tuesday", "Wed") as date strings and stripped them from article bylines. Tightens the regex so a weekday only counts when adjacent to a numeric date (day, month, or year), matching how human readers parse "Tuesday, March 5".Why this matters
The bug surfaces on email-style header blocks like the fixture added here, where stripping a standalone weekday clipped the byline. Reported in #233 with a real Substack-style article.
Changes
src/removals/content-patterns.ts- require a numeric date neighbor for the day-of-week match.tests/fixtures/metadata--email-style-header-block.html+tests/expected/metadata--email-style-header-block.md- regression fixture covering the reporter's case.Testing
New fixture passes locally. Existing fixtures still pass.
Fixes #233