fix: prevent adding space on styling bold#294
Open
lorenzozane wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#288 pointed out a spacing issue related to
<strong>tags conversion, which introduce extra spaces breaking up words that are partially bold for styling reasons.Example
https://eblog.fly.dev/ginbad.html#3-http-is-not-that-complicated-a-brief-review
The HyperText Transport Protocol has a client send HTTP Requests, and a server responds with HTTP Responses.
gets parsed as:
The H yper T ext T ransport P rotocol has a client send HTTP Requests, and a server responds with HTTP Responses.
Fix
The proposed change prevent spaces from being inserted inside words that are split across
<strong>tags, which could otherwise break up styled text incorrectly.Fixes #288