Skip to content

feat: add CDP-based interactive live view for headless Chromium (Approach 2 probably what BB is doing) #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hiroTamada wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: add CDP-based interactive live view for headless Chromium (Approach 2 probably what BB is doing) #176

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
75a5039
feat: add CDP-based interactive live view for headless Chromium
hiroTamada Mar 9, 2026
540ece5
fix: resolve data races in cdp-live-view and improve viewer UI
hiroTamada Mar 10, 2026
d5fd09f
fix: handle CDP disconnect recovery and stale msgId in benchmark
hiroTamada Mar 10, 2026
e37f5f7
fix: harden CDP client against disconnects and protocol errors
hiroTamada Mar 10, 2026
9825c1d
chore: remove scratch benchmark files from PR
hiroTamada Mar 10, 2026
00c97bf
fix: mutex-protect all viewer writes and clean up pending map on cancel
hiroTamada Mar 10, 2026
f94cb4f
fix: use attachToTarget session ID directly and remove dead sendBinary
hiroTamada Mar 10, 2026
cd8fa24
fix: sanitize navigate URLs and default live view to opt-in
hiroTamada Mar 10, 2026
2d9527e
fix: guard onDisconnect against stale CDP ref and fix double-click ev…
hiroTamada Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions images/chromium-headless/image/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ RUN --mount=type=cache,target=/root/.cache/go-build,id=$CACHEIDPREFIX-go-build \
GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH:-amd64} \
go build -ldflags="-s -w" -o /out/chromium-launcher ./cmd/chromium-launcher

# Build CDP live view server
RUN --mount=type=cache,target=/root/.cache/go-build,id=$CACHEIDPREFIX-go-build \
--mount=type=cache,target=/go/pkg/mod,id=$CACHEIDPREFIX-go-pkg-mod \
GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH:-amd64} \
go build -ldflags="-s -w" -o /out/cdp-live-view ./cmd/cdp-live-view

FROM docker.io/ubuntu:22.04 AS ffmpeg-downloader

# Allow cross-compilation when building with BuildKit platforms
Expand Down Expand Up @@ -237,6 +243,7 @@ RUN chmod +x /usr/local/bin/init-envoy.sh
# Copy the kernel-images API binary built in the builder stage
COPY --from=server-builder /out/kernel-images-api /usr/local/bin/kernel-images-api
COPY --from=server-builder /out/chromium-launcher /usr/local/bin/chromium-launcher
COPY --from=server-builder /out/cdp-live-view /usr/local/bin/cdp-live-view

# Copy and compile the Playwright daemon
COPY server/runtime/playwright-daemon.ts /tmp/playwright-daemon.ts
Expand Down
7 changes: 7 additions & 0 deletions images/chromium-headless/image/supervisor/services/cdp-live-view.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
[program:cdp-live-view]
command=/usr/local/bin/cdp-live-view
autostart=false
autorestart=true
startsecs=2
stdout_logfile=/var/log/supervisord/cdp-live-view
redirect_stderr=true
7 changes: 7 additions & 0 deletions images/chromium-headless/image/wrapper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ cleanup () {
echo "[wrapper] Cleaning up..."
# Re-enable scale-to-zero if the script terminates early
enable_scale_to_zero
supervisorctl -c /etc/supervisor/supervisord.conf stop cdp-live-view || true
supervisorctl -c /etc/supervisor/supervisord.conf stop chromedriver || true
supervisorctl -c /etc/supervisor/supervisord.conf stop chromium || true
supervisorctl -c /etc/supervisor/supervisord.conf stop xvfb || true
Expand Down Expand Up @@ -274,6 +275,12 @@ echo "[wrapper] Starting ChromeDriver via supervisord"
supervisorctl -c /etc/supervisor/supervisord.conf start chromedriver
wait_for_tcp_port 127.0.0.1 9225 "ChromeDriver" 50 0.2 "10s" || true

if [[ "${ENABLE_LIVE_VIEW:-}" == "true" ]]; then
echo "[wrapper] Starting CDP live view via supervisord"
supervisorctl -c /etc/supervisor/supervisord.conf start cdp-live-view
wait_for_tcp_port 127.0.0.1 8080 "cdp-live-view" 50 0.2 "10s" || true
fi

echo "[wrapper] startup complete!"
# Re-enable scale-to-zero once startup has completed (when not under Docker)
if [[ -z "${WITHDOCKER:-}" ]]; then
Expand Down
2 changes: 2 additions & 0 deletions images/chromium-headless/run-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ RUN_ARGS=(
-p 9222:9222
-p 9224:9224
-p 444:10001
-p 8080:8080
-v "$HOST_RECORDINGS_DIR:/recordings"
-e ENABLE_LIVE_VIEW="${ENABLE_LIVE_VIEW:-true}"
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
)

if [[ -n "${PLAYWRIGHT_ENGINE:-}" ]]; then
Expand Down
4 changes: 4 additions & 0 deletions images/chromium-headless/run-unikernel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,8 @@ deploy_args=(
-n "$NAME"
)

if [[ "${ENABLE_LIVE_VIEW:-}" == "true" ]]; then
deploy_args+=( -e ENABLE_LIVE_VIEW=true -p 443:8080/http+tls )
fi

kraft cloud inst create "${deploy_args[@]}" "$IMAGE"
Loading
Loading