Semi aggregated query for hardware details summary endpoint#1832
Open
alanpeixinho wants to merge 1 commit intokernelci:mainfrom
Open
Semi aggregated query for hardware details summary endpoint#1832alanpeixinho wants to merge 1 commit intokernelci:mainfrom
alanpeixinho wants to merge 1 commit intokernelci:mainfrom
Conversation
MarceloRobert
added
Backend
alanpeixinho
force-pushed
the
fix/improve-hardware-details-summary-performance
branch
10 times, most recently
from
9c304aa to
11b5c99
Compare
alanpeixinho
force-pushed
the
fix/improve-hardware-details-summary-performance
branch
2 times, most recently
from
162a78e to
93f201f
Compare
MarceloRobert
requested changes
Apr 6, 2026
Collaborator
MarceloRobert
left a comment
MarceloRobert
left a comment
There was a problem hiding this comment.
Seems like there's some discrepancy between the listing and the details, specially with larger hardware such as kubernetes
Comment on lines
-71
to
-74
| self.origin: str = None | ||
| self.start_datetime: datetime = None | ||
| self.end_datetime: datetime = None | ||
| self.selected_commits: Dict[str, str] = None |
Collaborator
There was a problem hiding this comment.
IMO you should keep at least these values since they are modified by unstable_parse_post_body and also won't have a typehint when used in the post method otherwise.
Comment on lines
+426
to
+439
| summary = Summary( | ||
| builds=builds_summary, boots=boots_summary, tests=tests_summary | ||
| ) | ||
| commons = HardwareCommon(trees=all_trees, compatibles=all_compatibles) | ||
| filters = HardwareDetailsFilters( | ||
| all=all_filters, | ||
| builds=builds_filters, | ||
| boots=boots_filters, | ||
| tests=tests_filters, | ||
| ) | ||
|
|
||
| valid_response = HardwareDetailsSummaryResponse( | ||
| summary=Summary( | ||
| builds=self.builds_summary, | ||
| boots=self.boots_summary, | ||
| tests=self.tests_summary, | ||
| ), | ||
| filters=HardwareDetailsFilters( | ||
| all=GlobalFilters( | ||
| configs=self.global_configs, | ||
| architectures=self.global_architectures, | ||
| compilers=self.global_compilers, | ||
| ), | ||
| builds=LocalFilters( | ||
| issues=list(self.unfiltered_build_issues), | ||
| has_unknown_issue=self.unfiltered_uncategorized_issue_flags[ | ||
| "build" | ||
| ], | ||
| origins=sorted(self.unfiltered_origins["build"]), | ||
| labs=sorted(self.unfiltered_labs["build"]), | ||
| ), | ||
| boots=HardwareTestLocalFilters( | ||
| issues=list(self.unfiltered_boot_issues), | ||
| platforms=list(self.unfiltered_boot_platforms), | ||
| has_unknown_issue=self.unfiltered_uncategorized_issue_flags[ | ||
| "boot" | ||
| ], | ||
| origins=sorted(self.unfiltered_origins["boot"]), | ||
| labs=sorted(self.unfiltered_labs["boot"]), | ||
| ), | ||
| tests=HardwareTestLocalFilters( | ||
| issues=list(self.unfiltered_test_issues), | ||
| platforms=list(self.unfiltered_test_platforms), | ||
| has_unknown_issue=self.unfiltered_uncategorized_issue_flags[ | ||
| "test" | ||
| ], | ||
| origins=sorted(self.unfiltered_origins["test"]), | ||
| labs=sorted(self.unfiltered_labs["test"]), | ||
| ), | ||
| ), | ||
| common=HardwareCommon( | ||
| trees=trees, | ||
| compatibles=self.compatibles, | ||
| ), | ||
| ) | ||
| except ValidationError as e: | ||
| return Response(data=e.json(), status=HTTPStatus.INTERNAL_SERVER_ERROR) | ||
| valid_response = HardwareDetailsSummaryResponse( | ||
| summary=summary, filters=filters, common=commons | ||
| ) |
Collaborator
There was a problem hiding this comment.
I'd wrap all this in a try except just in case we get a ValidationError
Contributor
Author
There was a problem hiding this comment.
You are correct, as it is, I am changing behavior unnecessarily
Collaborator
|
Good code though, very organized 👍 |
alanpeixinho
force-pushed
the
fix/improve-hardware-details-summary-performance
branch
2 times, most recently
from
409f8ed to
0002e6c
Compare
alanpeixinho
force-pushed
the
fix/improve-hardware-details-summary-performance
branch
from
0002e6c to
a19b158
Compare
Contributor
Author
I happened due to a misunderstanding in the filtering of dummy builds. Should be correct now. |
alanpeixinho
commented
Apr 7, 2026
| "base_hardware, filters", | ||
| [ | ||
| (ASUS_HARDWARE, {"config_name": "defconfig+kcidebug+x86-board"}), | ||
| (ASUS_HARDWARE, {"config_name": "defconfig"}), |
Contributor
Author
There was a problem hiding this comment.
Check if this is change is correct.
alanpeixinho
commented
Apr 7, 2026
| "base_hardware, filters", | ||
| [ | ||
| (ASUS_HARDWARE, {"architecture": "i386"}), | ||
| (ASUS_HARDWARE, {"architecture": "asus-CM1400CXA-dalboz"}), |
Contributor
Author
There was a problem hiding this comment.
Check if this is change is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implements performance improvement on the Hardware details summary endpoint.
How to test