V1.5 SuperSocket.SocketEngine.SocketSession.OnSendingCompleted NullReferenceException

[Arisoo]

raised NullReferenceException on SuperSocket.SocketEngine.SocketSession.OnSendingCompleted(...)

but. my 1.5.1 SocketSession.cs and this repository's 1.5 SocketSession.cs was different.
so. maybe not bug on this repository's 1.5 version
yet. review this

    protected virtual void OnSendingCompleted(SendingQueue queue)
    {
        queue.Clear();
        m_SendingQueuePool.Push(queue);

        if (IsInClosingOrClosed)
        {
            RemoveStateFlag(SocketState.InSending);
            return;
        }

        var newQueue = m_SendingQueue;

        // A: raise System.NullReferenceException, as OnClose set m_SendingQueue into NULL
        if (newQueue.Count == 0)     
        {
            RemoveStateFlag(SocketState.InSending);

            if (newQueue.Count > 0)
            {
                StartSend(newQueue, newQueue.TrackID, true);
            }
        }
        else
        {
            StartSend(newQueue, newQueue.TrackID, false);
        }
    }

    // OnSendingComplete and OnClosed concurrently threaded on same SocketSession
    //    
    protected virtual void OnClosed(CloseReason reason)
    {
        AddStateFlag(SocketState.Closed);

        //Before changing m_SendingQueue, must check m_IsClosed
        while (true)
        {
            var sendingQueue = m_SendingQueue;

            if (sendingQueue == null)
                break;

            // B: I suppose above code raise NullReference whole OnSendingCompleted threading
            //There is no sending was started after the m_Closed ws set to 'true'
            if (Interlocked.CompareExchange(ref m_SendingQueue, null, sendingQueue) == sendingQueue)
            {
                sendingQueue.Clear();
                m_SendingQueuePool.Push(sendingQueue);
                break;
            }
        }

        var closedHandler = Closed;
        if (closedHandler != null)
        {
            closedHandler(this, reason);
        }
    }

That exception very rarely raise.
code A raise exception after code B was executed on concurrently.

Thanks~

=========================================
this problem solved at supersocket 1.6.7 ~~!!!
Must use supersocket version 1.6.7 later~
Thanks kerryjiang!

[kerryjiang]

Oh, it seems you send the PR to the wrong branch.

[kerryjiang]

Could you check if v1.6 has fixed this issue?

[Arisoo]

OK I'll try patch 1.6 ~
Thanks~

[Arisoo]

Hello again. it's so hacked.. late.. sorry~

I'll make some echo client and echo server
1 server process, 200 thread connection X 4
that problem solved !!! at 1.6.7 (stilll ok about 12 hours~)
(ref: that crash raised about 1 hour at 1.5.1)

so We must use 1.6.7 supersocket and superwebsocket 0.10.0

Thank you !!!