Skip to content

Fix start_scan() and get_scan_status() #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khers merged 1 commit into from
May 13, 2026
Merged

Fix start_scan() and get_scan_status() #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libopensonic/_async/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1401,7 +1401,7 @@ async def get_scan_status(self) -> ScanStatus:
res = await self._do_request(method)
dres = await self._handle_info_res(res)
self._check_status(dres)
return ScanStatus.from_dict(dres['scanstatus'])
return ScanStatus.from_dict(dres['scanStatus'])


async def get_shares(self) -> list[Share]:
Expand Down Expand Up @@ -2057,7 +2057,7 @@ async def start_scan(self) -> ScanStatus:
res = await self._do_request(method)
dres = await self._handle_info_res(res)
self._check_status(dres)
return ScanStatus.from_dict(dres['scanstatus'])
return ScanStatus.from_dict(dres['scanStatus'])


async def stream(self, sid:str, max_bit_rate:int=0, tformat:str|None=None,
Expand Down
4 changes: 2 additions & 2 deletions src/libopensonic/_sync/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1401,7 +1401,7 @@ def get_scan_status(self) -> ScanStatus:
res = self._do_request(method)
dres = self._handle_info_res(res)
self._check_status(dres)
return ScanStatus.from_dict(dres['scanstatus'])
return ScanStatus.from_dict(dres['scanStatus'])


def get_shares(self) -> list[Share]:
Expand Down Expand Up @@ -2057,7 +2057,7 @@ def start_scan(self) -> ScanStatus:
res = self._do_request(method)
dres = self._handle_info_res(res)
self._check_status(dres)
return ScanStatus.from_dict(dres['scanstatus'])
return ScanStatus.from_dict(dres['scanStatus'])


def stream(self, sid:str, max_bit_rate:int=0, tformat:str|None=None,
Expand Down
6 changes: 4 additions & 2 deletions test/test_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,7 +1446,7 @@ class TestScanExtensions:
async def test_get_scan_status(self, conn, mock_session, mock_response):
"""Test get_scan_status."""
status = {
"scanstatus": {
"scanStatus": {
"scanning": False,
"count": 1000
}
Expand All @@ -1457,12 +1457,13 @@ async def test_get_scan_status(self, conn, mock_session, mock_response):
result = await conn.get_scan_status()
assert isinstance(result, ScanStatus)
assert result.scanning is False
assert result.count == 1000

@pytest.mark.asyncio
async def test_start_scan(self, conn, mock_session, mock_response):
"""Test start_scan."""
status = {
"scanstatus": {
"scanStatus": {
"scanning": True,
"count": 0
}
Expand All @@ -1473,6 +1474,7 @@ async def test_start_scan(self, conn, mock_session, mock_response):
result = await conn.start_scan()
assert isinstance(result, ScanStatus)
assert result.scanning is True
assert result.count == 0

@pytest.mark.asyncio
async def test_get_open_subsonic_extensions(self, conn, mock_session, mock_response):
Expand Down
Loading