46 permutations#51
Open
kitano-kazuki wants to merge 5 commits into
Open
Conversation
nodchip
reviewed
May 18, 2026
| all_permutations = [] | ||
|
|
||
| permutation = [] | ||
| used_indices = set() |
There was a problem hiding this comment.
used_indices = [False] * len(nums)とすると、ハッシュの計算や、バケットのインデックスの計算が省け、軽くなると思います。
5ky7
reviewed
May 29, 2026
| class Solution: | ||
| def permute(self, nums: list[int]) -> list[list[int]]: | ||
|
|
||
| def generate_permutations(candidates: list[int], permutations: list[list[int]]): |
There was a problem hiding this comment.
引数に型ヒントつけるなら，返り値の型ヒントもつけてはいかがでしょうか（Pythonのプラクティスでは返り値にはいちいちヒントをつけないこともある，とかだったらスルーしてください）
Owner
Author
There was a problem hiding this comment.
返り値の型ヒントもあった方が親切そうです！
|
|
||
| ## Code2-1 | ||
|
|
||
| * 「今注目している候補以外でできるpermutationに候補を加える」という動作がわかりやすくなるようにした |
| * 今回は, デバッグのしやすさと解法の幅の観点から, 一つ一つのpermutationごとにstackに入れるようにした | ||
| * 一つのpermutationごとに次に選ぶ候補を保存しておく | ||
|
|
||
| ```python |
Comment on lines
+172
to
+174
|
|
||
| generate_permutations() | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/permutations/description/