8. String to Integer (atoi)#60
Open
kitano-kazuki wants to merge 1 commit into
Open
Conversation
Yuto729
reviewed
May 24, 2026
| is_leading_zeroes = False | ||
| num = 0 | ||
| while i < len(s) and s[i].isdecimal(): | ||
| if is_leading_zeroes: |
There was a problem hiding this comment.
is_leading_zeroesがデフォルトfalseなのでこちらの分岐には入らない気がします
leading zeroの扱いについては特に考慮しなくて良いので結果的に正しく動いてるということでしょうか
Owner
Author
There was a problem hiding this comment.
これは動かないですね。きっと。。。。
leetcode上にコピペして, leetcodeのエディタで行った修正をこっちに反映し忘れたのだとおもいます
|
|
||
| is_leading_zeroes = False | ||
| num = 0 | ||
| while i < len(s) and s[i].isdecimal(): |
There was a problem hiding this comment.
isdecimalは「Unicode の decimal digit 全般」を表すため今回はUnicodeポイントを直接比較する方が良いと思います。'0' <= c <= '9'
https://docs.python.org/3/library/stdtypes.html#str.isdecimal
Owner
Author
There was a problem hiding this comment.
知らなかったです。ありがとうございます
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/string-to-integer-atoi/description/