Skip to content

6. Zigzag Conversion#61

Open
kitano-kazuki wants to merge 1 commit into
mainfrom
6-zigzag-conversion
Open

6. Zigzag Conversion#61
kitano-kazuki wants to merge 1 commit into
mainfrom
6-zigzag-conversion

Conversation

@kitano-kazuki
Copy link
Copy Markdown
Owner

Copy link
Copy Markdown

@Yuto729 Yuto729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体的にコードがきれいで良いと思いました

Comment thread memo.md
Comment on lines +131 to +135
result = []
for ch_list in row_chars:
result.extend(ch_list)

return "".join(result)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"".join(c for row in rows for c in row)
こう書けたりもしますね

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かに簡潔にかけてそちらもいいですね!
今回は, 処理の内容を順をおって理解できるように内包forは避けました

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants