Skip to content

Fixing PanelManager error#1

Open
nuriyevn wants to merge 2 commits into
kmashint:masterfrom
nuriyevn:master
Open

Fixing PanelManager error#1
nuriyevn wants to merge 2 commits into
kmashint:masterfrom
nuriyevn:master

Conversation

@nuriyevn
Copy link
Copy Markdown

@nuriyevn nuriyevn commented Dec 4, 2018

Error: Module name "view/PanelManager" has not been loaded yet for context:

Error: Module name "view/PanelManager" has not been loaded yet for context:
KeyBindings changed from Ctrl-Alt-B to Ctrl-Shift-B and Ctrl-Shift-N, as there is a shortcut collision and for convenient reason
Comment thread main.js

KeyBindingManager.addBinding('builder.build', 'Ctrl-Alt-B');
KeyBindingManager.addBinding('builder.build', 'Ctrl-Shift-B');
KeyBindingManager.addBinding('builder.build', 'Ctrl-Shift-N');
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using OSX? I'm on Windows and Ctrl-Alt-B is the best since Ctrl-Shift-B must be taken for something else. If Ctrl-Shift-B is better for OSX I can check the OS type and switch accordingly.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just noticed that I have another plugin which is Called "Brackets Beautify" and ironically it is a single plugin so far and it also uses this shortcut Ctrl-Alt-B to make formatting, so that's not mandatory to accept the key bindings in the commit :)
I use linux (ubuntu)
neither brackets
https://github.com/adobe/brackets/wiki/Brackets-Shortcuts
nor ubuntu
https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts
have predefined Ctrl -Alt - B.
IMHO, what we can do is to set the Key Binding in config.json and then load in course, I think that will be a better decision than OS differentiation, it's to complicated and we can not rely on default scenario.

MacOS
https://support.apple.com/en-us/HT201236
And windows
https://support.microsoft.com/en-ca/help/12445/windows-keyboard-shortcuts

There can be another application which globally override this combination , so we should let the user to choose whatever if default does not work for him(her).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants