Fixing PanelManager error#1
Conversation
Error: Module name "view/PanelManager" has not been loaded yet for context:
KeyBindings changed from Ctrl-Alt-B to Ctrl-Shift-B and Ctrl-Shift-N, as there is a shortcut collision and for convenient reason
|
|
||
| KeyBindingManager.addBinding('builder.build', 'Ctrl-Alt-B'); | ||
| KeyBindingManager.addBinding('builder.build', 'Ctrl-Shift-B'); | ||
| KeyBindingManager.addBinding('builder.build', 'Ctrl-Shift-N'); |
There was a problem hiding this comment.
Are you using OSX? I'm on Windows and Ctrl-Alt-B is the best since Ctrl-Shift-B must be taken for something else. If Ctrl-Shift-B is better for OSX I can check the OS type and switch accordingly.
There was a problem hiding this comment.
I have just noticed that I have another plugin which is Called "Brackets Beautify" and ironically it is a single plugin so far and it also uses this shortcut Ctrl-Alt-B to make formatting, so that's not mandatory to accept the key bindings in the commit :)
I use linux (ubuntu)
neither brackets
https://github.com/adobe/brackets/wiki/Brackets-Shortcuts
nor ubuntu
https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts
have predefined Ctrl -Alt - B.
IMHO, what we can do is to set the Key Binding in config.json and then load in course, I think that will be a better decision than OS differentiation, it's to complicated and we can not rely on default scenario.
MacOS
https://support.apple.com/en-us/HT201236
And windows
https://support.microsoft.com/en-ca/help/12445/windows-keyboard-shortcuts
There can be another application which globally override this combination , so we should let the user to choose whatever if default does not work for him(her).
Error: Module name "view/PanelManager" has not been loaded yet for context: