Integration property tests#122
Open
kirloo wants to merge 13 commits into
Open
Conversation
Owner
|
Thanks for taking this! This is a non trivial change so I'll need a day or two to review this (I'm also traveling atm). Will get back soon! |
rtmongold
reviewed
Jul 11, 2026
kmolan
reviewed
Jul 11, 2026
kmolan
reviewed
Jul 11, 2026
kmolan
requested changes
Jul 11, 2026
Owner
|
@kirloo Left comments. Please also add tests for other quadratures when ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Resolves #102
I haven't touched
gaussian_tablesyet, but I'm submitting a draft because while the test logic looks sound, I had to increase the number of iterations all the way to 300 for the Simpsons test to pass. I don't know whether that's indicative of an error somewhere, or expected for that method due to the relatively larger intervals, but the discrepancy made me nervous.Checklist
## [Unreleased](required for behavior-facing changes)cargo test+cargo clippy --all-targetsclean locallyunwrap/expect/panicon library paths (typed errors instead)