Feature: Add RISC-V target to embedded-smoke#140
Open
rtmongold wants to merge 1 commit into
Open
Conversation
rtmongold
force-pushed
the
feature/riscv-embedded-smoke
branch
5 times, most recently
from
6bced4d to
70b1bb3
Compare
rtmongold
force-pushed
the
feature/riscv-embedded-smoke
branch
from
70b1bb3 to
9626da8
Compare
kmolan
reviewed
Jul 14, 2026
| [target.riscv32imc-unknown-none-elf] | ||
| runner = "qemu-system-riscv32 -machine virt -nographic -semihosting-config enable=on,target=native -bios none -kernel" | ||
| rustflags = [ | ||
| "-C", "link-arg=-Tmemory.x", # must come before link x for riscv-rt |
Owner
There was a problem hiding this comment.
"must come before link x for riscv-rt" why is that?
kmolan
reviewed
Jul 14, 2026
| # thumbv7em ABIs run the full set. The bare set is the same for representative | ||
| # and full runs — full only adds the aarch64 host. | ||
| bare='[{"target":"thumbv7em-none-eabi","args":""},{"target":"thumbv7em-none-eabihf","args":""},{"target":"thumbv6m-none-eabi","args":"--no-default-features"}]' | ||
| # thumbv7em ABIs and riscv32 run the full set. The bare set is the same for |
kmolan
reviewed
Jul 14, 2026
| - name: Install QEMU (RISC-V) | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y qemu-system-misc |
Owner
There was a problem hiding this comment.
do not do apt install. Rather stick with cached deps similar to how the arm is installed above.
Owner
There was a problem hiding this comment.
reason is to avoid the slow apt update and apt install on every CI
kmolan
requested changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99
Add RISC-V target to embedded-smoke
Checklist
## [Unreleased](required for behavior-facing changes)cargo test+cargo clippy --all-targetsclean locallyunwrap/expect/panicon library paths (typed errors instead)