Skip to content

Fix flaky TestMinScaleAnnotationChange by waiting for scale convergence #16668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brucearctor wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

Fix flaky TestMinScaleAnnotationChange by waiting for scale convergence #16668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/e2e/minscale_readiness_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,14 @@ func TestMinScaleAnnotationChange(t *testing.T) {
serviceName := PrivateServiceName(t, clients, revName)
revClient := clients.ServingClient.Revisions

// Wait for the KPA to reconcile and scale to converge before
// asserting stability. The Service can report Ready before the
// deployment has reached the desired replica count.
// See: https://github.com/knative/serving/issues/16653
if lr, err := waitForDesiredScale(clients, serviceName, eq(minScale[0])); err != nil {
t.Fatalf("The revision %q never reached scale %d: last observed %d", revName, minScale[0], lr)
}

t.Log("Holding revision at minScale after becoming ready")
if lr, ok := ensureDesiredScale(clients, t, serviceName, eq(minScale[0])); !ok {
t.Fatalf("The revision %q observed scale %d < %d after becoming ready", revName, lr, minScale)
Expand Down