Use registry.localhost in e2e CI workflow#16669
Open
linkvt wants to merge 1 commit into
Open
Conversation
|
Skipping CI for Draft Pull Request. |
knative-prow
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: linkvt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
size/XS
linkvt
force-pushed
the
fix-e2e-ko-sbom-push
branch
from
July 22, 2026 08:13
8a6f35b to
68f9eb4
Compare
knative-prow
Bot
added
size/S
linkvt
changed the title
linkvt
force-pushed
the
fix-e2e-ko-sbom-push
branch
from
July 22, 2026 08:15
68f9eb4 to
dfff8ed
Compare
go-containerregistry PR knative#2281 (included in v0.21.6) narrowed the insecure HTTP fallback heuristic from *.local to *.localhost only. ko v0.19.0 picked this up via its dependency bump, breaking the e2e workflow's local registry push with: Get "https://registry.local:5000/v2/": http: server gave HTTP response to HTTPS client Rename the registry from registry.local to registry.localhost to match the new heuristic. This aligns with RFC 6761 (*.localhost is the correct domain for loopback services; *.local is mDNS per RFC 6762). Also pass registry-authority to setup-kind so the test job's registry uses the same hostname. Signed-off-by: Vincent Link <vlink@redhat.com>
linkvt
force-pushed
the
fix-e2e-ko-sbom-push
branch
from
July 22, 2026 08:45
dfff8ed to
31eedf0
Compare
linkvt
marked this pull request as ready for review
July 22, 2026 11:04
knative-prow
Bot
removed
the
do-not-merge/work-in-progress
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16669 +/- ##
==========================================
+ Coverage 80.29% 80.35% +0.05%
==========================================
Files 217 217
Lines 13568 13568
==========================================
+ Hits 10895 10902 +7
+ Misses 2308 2304 -4
+ Partials 365 362 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go-containerregistry PR #2281 (in v0.21.6) narrowed the insecure HTTP fallback from
*.localto*.localhostonly. ko v0.19.0 picked this up, breaking the e2e workflow's local registry push:Renaming the registry from
registry.localtoregistry.localhostfixes this.Might need to cherry-pick this onto release branches in case they also use the latest ko version.
Changes
registry.localtoregistry.localhostin e2e workflowregistry-authoritytosetup-kindto match