refactor: better accessbility for tabs.#68
Merged
knightedcodemonkey merged 2 commits intonextfrom Apr 11, 2026
Merged
Conversation
Owner
knightedcodemonkey
commented
Apr 11, 2026
knightedcodemonkey
commented
- fixes Improve workspace tabs semantic HTML and accessibility structure #66
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the workspace tabs area to use more semantic HTML and a clearer accessibility model (issue #66), while updating the add-tab menu interactions and aligning related styling and tests.
Changes:
- Reworks workspace tabs markup from generic containers + tab roles to a
<nav>+<ul>/<li>structure, and updates the add-tab menu labeling/roles. - Improves add-tab menu keyboard focus management (focus first item on open; restore focus to trigger on Escape close).
- Adjusts preview background defaulting behavior across themes and updates Playwright tests to match the new semantics/behavior.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.html | Tabs region markup switched to <nav>/<ul>; add-tab control/menu semantics updated; preview bg color input default changed. |
| src/app.js | Workspace tab rendering updated for <li> containers and new ARIA state; add-tab menu focus management added; preview bg controller now theme-aware. |
| src/modules/preview-background.js | Adds theme-aware default resolution and changes initialization/sync behavior for preview background color. |
| src/styles/layout-shell.css | Removes list styling on the new <ul>-based tab strip (list-style/margin/padding reset). |
| src/styles/panels-editor.css | Active tab styling moved from [aria-selected] to [data-active]; minor collapsed preview control hiding adjustments. |
| src/styles/base.css | Removes unused accent custom properties. |
| src/styles/ai-controls.css | Removes unused repo select styling rules. |
| playwright/workspace-tabs.spec.ts | Updates selectors/assertions from tab roles to button semantics; adds keyboard focus test for add menu. |
| playwright/rendering-modes.spec.ts | Updates selectors from tab roles to button semantics. |
| playwright/layout-panels.spec.ts | Adds coverage for theme-dependent preview background defaults; updates tab selectors. |
| playwright/helpers/app-test-helpers.ts | Updates helpers to use new add-tab labels and button selectors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.