Feature favorites by ogardoni · Pull Request #19 · knivram/PasswordSafe

ogardoni · 2025-07-01T13:25:39Z

Here's a comprehensive merge request description for the reviewer:

🌟 Add Favorites Functionality to Password Safe

Overview

This PR implements a complete favorites system that allows users to mark secrets as favorites and view them in a dedicated page. The feature includes optimistic UI updates for instant feedback and maintains data consistency across all views.

🚀 What's New

Core Features

⭐ Mark secrets as favorites - Users can star/unstar secrets with a single click
📱 Dedicated favorites page - New /app/favorites route to view all favorite secrets
🔄 Optimistic updates - Instant UI feedback with automatic rollback on errors
🧭 Enhanced navigation - Added "Favorites" link in sidebar with proper active state

User Experience Improvements

Instant visual feedback - Star icons update immediately when clicked
Cross-view synchronization - Changes reflect across all secret lists instantly
Vault context preserved - Favorites view shows which vault each secret belongs to
Graceful error handling - Failed requests automatically revert UI changes

📁 Files Changed

Database & Types

schema.prisma - Added isFavorite boolean field to Secret model
secret.ts - Updated interfaces to include favorite status

Backend (Server Actions)

_secretActions.ts - Added toggle and fetch actions for favorites

Frontend (Client-Side)

secrets-client.ts - Added methods for favorites with encryption support
secrets-list.tsx - Added star UI, optimistic updates, and FavoriteSecretsList component
sidebar-vault-list.tsx - Added favorites navigation link
page.tsx - New favorites page component

🔧 Technical Implementation

Database Schema

-- Added to Secret table
isFavorite BOOLEAN DEFAULT false

Key Components

Star Button - Clickable star icon with visual states (filled/outlined)
Optimistic Updates - Immediate UI changes before server confirmation
Query Invalidation - Smart cache management across related views
Error Recovery - Automatic UI rollback on failed requests

API Endpoints

toggleSecretFavorite(secretId) - Toggle favorite status
getFavoriteSecretsWithVaults() - Fetch only favorite secrets

🎯 Business Logic

Favorite Toggle Rules

✅ Available in vault-specific secret lists
✅ Available in all-secrets view
✅ Available in favorites view
❌ NOT available in create/edit dialogs (as specified)

Data Synchronization

Favorites are user-specific and vault-permission aware
Changes sync across all views (vault lists, all-secrets, favorites)
Deleted secrets are automatically removed from favorites

🧪 Testing Scenarios

Happy Path

User clicks star → UI updates instantly → Server confirms → Data stays synced
Navigate to favorites → See all starred secrets with vault badges
Click vault badge → Jump to specific vault view

Error Handling

Network failure → UI reverts to previous state → Error toast shown
Permission denied → Error handling with appropriate messaging

Cross-View Consistency

Star secret in vault view → Appears in favorites instantly
Unstar in favorites → Removed from all views
Delete secret → Removed from favorites automatically

🔒 Security Considerations

Maintains existing vault permission system
Favorite status follows vault access rules
End-to-end encryption preserved for secret data
No additional attack surface introduced

📱 UI/UX Design

Visual Elements

Filled yellow star ⭐ - Favorited secrets
Outlined star ☆ - Non-favorite secrets
Hover effects - Star highlights on hover
Sidebar navigation - Clear favorites section

Responsive Behavior

Works on all screen sizes
Touch-friendly on mobile devices
Keyboard navigation support

🚦 Migration Strategy

Database migration included for isFavorite field
Backward compatible - existing secrets default to non-favorite
Zero downtime deployment possible

✅ Ready for Review

Code Quality

TypeScript strict mode compliance
Consistent error handling patterns
Proper loading states and skeletons
Clean component separation

Performance

Optimistic updates reduce perceived latency
Efficient query invalidation strategy
Minimal re-renders with React Query

Reviewer Notes:

Focus on the optimistic update logic in handleToggleFavorite
Verify the query invalidation strategy covers all edge cases
Check that favorite functionality is properly excluded from create/edit flows
Ensure the database migration is safe for production

- Add isFavorite boolean field to Secret schema with default false - Update SecretWithDecryptedData interface to include isFavorite - Database migration ready for favorite functionality

- Add toggleSecretFavorite action to toggle favorite status - Add getFavoriteSecretsWithVaults action to fetch only favorites - Update getAllSecretsWithVaults to include isFavorite field - Proper error handling and authorization checks

- Add getFavoriteSecretsWithDecryptedData method - Add toggleFavorite method for optimistic updates - Update existing methods to include isFavorite field - Import and integrate new server actions

- Create /app/favorites route for viewing favorite secrets - Display starred secrets from all vaults with vault badges - Include descriptive header and empty state messaging

- Add Star icon import and star button to each secret card - Implement handleToggleFavorite with optimistic updates - Add FavoriteSecretsList component for favorites page - Update query invalidation to include favorites - Add FAVORITE_SECRETS_QUERY_KEY constant - Optimistic UI updates with error rollback handling

- Add Star icon import and favorites navigation item - Add pathname detection for active state highlighting - Place favorites link after 'All Secrets' in navigation - Update both error and success states to include favorites

vercel · 2025-07-01T13:25:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
password-safe	❌ Failed (Inspect)			Jul 8, 2025 0:10am

knivram · 2025-07-03T05:52:16Z

+                  variant="ghost"
+                  size="sm"
+                  onClick={() => handleToggleFavorite(secret)}
+                  className="p-1"


Why is this needed?

Co-authored-by: Marvin <129607867+knivram@users.noreply.github.com>

…ndling

- Add isFavorite boolean field to Secret schema with default false - Update SecretWithDecryptedData interface to include isFavorite - Database migration ready for favorite functionality

- Add toggleSecretFavorite action to toggle favorite status - Add getFavoriteSecretsWithVaults action to fetch only favorites - Update getAllSecretsWithVaults to include isFavorite field - Proper error handling and authorization checks

- Add getFavoriteSecretsWithDecryptedData method - Add toggleFavorite method for optimistic updates - Update existing methods to include isFavorite field - Import and integrate new server actions

- Create /app/favorites route for viewing favorite secrets - Display starred secrets from all vaults with vault badges - Include descriptive header and empty state messaging

- Add Star icon import and star button to each secret card - Implement handleToggleFavorite with optimistic updates - Add FavoriteSecretsList component for favorites page - Update query invalidation to include favorites - Add FAVORITE_SECRETS_QUERY_KEY constant - Optimistic UI updates with error rollback handling

- Add Star icon import and favorites navigation item - Add pathname detection for active state highlighting - Place favorites link after 'All Secrets' in navigation - Update both error and success states to include favorites

Co-authored-by: Marvin <129607867+knivram@users.noreply.github.com>

…ndling

…nto feature-favorites

Co-authored-by: Marvin <129607867+knivram@users.noreply.github.com>

knivram and others added 8 commits June 29, 2025 18:20

implemented all secrets view

5b6e155

feat: add isFavorite field to Secret model and update types

8ad9e3c

- Add isFavorite boolean field to Secret schema with default false - Update SecretWithDecryptedData interface to include isFavorite - Database migration ready for favorite functionality

feat: add server actions for favorite secrets

8cf9535

- Add toggleSecretFavorite action to toggle favorite status - Add getFavoriteSecretsWithVaults action to fetch only favorites - Update getAllSecretsWithVaults to include isFavorite field - Proper error handling and authorization checks

feat: add favorites support to secrets client

0261c90

- Add getFavoriteSecretsWithDecryptedData method - Add toggleFavorite method for optimistic updates - Update existing methods to include isFavorite field - Import and integrate new server actions

feat: add favorites page

57b9047

- Create /app/favorites route for viewing favorite secrets - Display starred secrets from all vaults with vault badges - Include descriptive header and empty state messaging

feat: add favorites navigation to sidebar

d5dd134

- Add Star icon import and favorites navigation item - Add pathname detection for active state highlighting - Place favorites link after 'All Secrets' in navigation - Update both error and success states to include favorites

fix code style

b337140

ogardoni requested a review from knivram July 1, 2025 13:25

Merge branch 'main' into feature-favorites

8454eab

vercel Bot deployed to Preview July 3, 2025 05:46 View deployment

knivram requested changes Jul 3, 2025

View reviewed changes

Update components/secrets-list.tsx

bb9e6c6

Co-authored-by: Marvin <129607867+knivram@users.noreply.github.com>

vercel Bot deployed to Preview July 8, 2025 09:15 View deployment

vercel Bot deployed to Preview July 8, 2025 09:52 View deployment

refactor getAllSecretsWithVaults for improvedreadability and error ha…

40f5de7

…ndling

ogardoni force-pushed the feature-favorites branch from a98a36d to 40f5de7 Compare July 8, 2025 09:55

vercel Bot deployed to Preview July 8, 2025 09:56 View deployment

ogardoni and others added 11 commits July 8, 2025 13:41

fix merge conflicts

28834b6

feat: add isFavorite field to Secret model and update types

8f92292

- Add isFavorite boolean field to Secret schema with default false - Update SecretWithDecryptedData interface to include isFavorite - Database migration ready for favorite functionality

feat: add server actions for favorite secrets

2c6166e

- Add toggleSecretFavorite action to toggle favorite status - Add getFavoriteSecretsWithVaults action to fetch only favorites - Update getAllSecretsWithVaults to include isFavorite field - Proper error handling and authorization checks

feat: add favorites support to secrets client

5106e2d

- Add getFavoriteSecretsWithDecryptedData method - Add toggleFavorite method for optimistic updates - Update existing methods to include isFavorite field - Import and integrate new server actions

feat: add favorites page

5d23ff5

- Create /app/favorites route for viewing favorite secrets - Display starred secrets from all vaults with vault badges - Include descriptive header and empty state messaging

feat: add favorites navigation to sidebar

caa6d58

- Add Star icon import and favorites navigation item - Add pathname detection for active state highlighting - Place favorites link after 'All Secrets' in navigation - Update both error and success states to include favorites

fix code style

33c4f1e

Update components/secrets-list.tsx

8008f56

Co-authored-by: Marvin <129607867+knivram@users.noreply.github.com>

refactor getAllSecretsWithVaults for improvedreadability and error ha…

f2013a7

…ndling

Merge branch 'feature-favorites' of github.com:knivram/PasswordSafe i…

c9e48b0

…nto feature-favorites

vercel Bot had a problem deploying to Preview July 8, 2025 12:09 Failure

Update app/actions/_secretActions.ts

becd135

Co-authored-by: Marvin <129607867+knivram@users.noreply.github.com>

vercel Bot had a problem deploying to Preview July 8, 2025 12:10 Failure

knivram closed this Feb 21, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature favorites#19

Feature favorites#19
ogardoni wants to merge 23 commits into
mainfrom
feature-favorites

ogardoni commented Jul 1, 2025

Uh oh!

vercel Bot commented Jul 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

knivram Jul 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ogardoni commented Jul 1, 2025

🌟 Add Favorites Functionality to Password Safe

Overview

🚀 What's New

Core Features

User Experience Improvements

📁 Files Changed

Database & Types

Backend (Server Actions)

Frontend (Client-Side)

🔧 Technical Implementation

Database Schema

Key Components

API Endpoints

🎯 Business Logic

Favorite Toggle Rules

Data Synchronization

🧪 Testing Scenarios

Happy Path

Error Handling

Cross-View Consistency

🔒 Security Considerations

📱 UI/UX Design

Visual Elements

Responsive Behavior

🚦 Migration Strategy

✅ Ready for Review

Code Quality

Performance

Uh oh!

vercel Bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

knivram Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Jul 1, 2025 •

edited

Loading