Skip to content

feat(KNO-13529): Docs for Knock hosted preference center (w/o custom domains)#1474

Open
andy-knock wants to merge 1 commit into
mainfrom
knock-hosted-preference-center
Open

feat(KNO-13529): Docs for Knock hosted preference center (w/o custom domains)#1474
andy-knock wants to merge 1 commit into
mainfrom
knock-hosted-preference-center

Conversation

@andy-knock
Copy link
Copy Markdown
Contributor

@andy-knock andy-knock commented Jun 4, 2026

Screenshot 2026-06-04 at 3.36.42 PM.pngScreenshot 2026-06-04 at 3.36.37 PM.png

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jun 4, 2026 7:39pm

Request Review

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Comment thread content/preferences/hosted-preference-center.mdx
<code>false</code>, the notification won't be delivered. See{" "}
<a href="/preferences/overview#preference-evaluation-rules">
preference evaluation rules
</a>{" "}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate preference evaluation links

Low Severity

preference evaluation and preference evaluation rules both link to /preferences/overview#preference-evaluation-rules on the same page. Only the first mention should stay linked.

Additional Locations (1)
Fix in Cursor Fix in Web

Triggered by learned rule: Link Knock concepts on first mention only per page

Reviewed by Cursor Bugbot for commit 79b2b1d. Configure here.

Comment thread content/preferences/overview.mdx Outdated
@andy-knock andy-knock force-pushed the knock-hosted-preference-center branch from 245b33e to aafe2de Compare June 4, 2026 19:36
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit aafe2de. Configure here.

<Callout
type="info"
title="Users only."
text="The hosted preference center currently supports user recipients only. It doesn't support managing preferences for objects or tenants."
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tenants objects first links

Low Severity

The “Users only” callout’s first mention of objects and tenants is plain text. Knock concept terms should link to their concept pages on first mention only (e.g. /concepts/objects, /concepts/tenants).

Fix in Cursor Fix in Web

Triggered by learned rule: Link Knock concepts on first mention only per page

Reviewed by Cursor Bugbot for commit aafe2de. Configure here.

@andy-knock andy-knock requested a review from cellomatt June 4, 2026 19:37
@andy-knock andy-knock changed the title feat() Docs for Knock hosted preference center (w/o custom domains) feat(KNO-13529): Docs for Knock hosted preference center (w/o custom domains) Jun 4, 2026
@andy-knock andy-knock marked this pull request as ready for review June 4, 2026 20:25
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Jun 4, 2026

KNO-13529

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk MEDIUM: Adds new documentation page for Knock's hosted preference center with sidebar navigation changes and updates to the existing preferences overview page.

Reasons

  • A new MDX page was added (content/preferences/hosted-preference-center.mdx with 137 lines), which triggers MEDIUM per the new-page rule.
  • The sidebar navigation file data/sidebars/platformSidebar.ts was modified to include the new page entry, which triggers MEDIUM per the sidebar-change rule.
  • The diff is content-focused with no component, layout, style, or build configuration changes, so no HIGH triggers apply.
  • All changes are scoped to a single documentation section (content/preferences/), so cross-section risk does not apply.
  • Total diff is 158 additions and 2 deletions across 3 files — moderate scope with no destructive changes.

Notes

  • Verify the new sidebar entry renders correctly and the page appears in the expected position under the Preferences section (between "Overview" and "Object preferences").
  • Confirm all internal links in the new page resolve correctly, especially /preferences/overview#how-preferences-work, /preferences/overview#preference-evaluation-rules, /preferences/overview#merging-preferences, /preferences/commercial-unsubscribe, /template-editor/branding, /integrations/email/layouts, and /preferences/overview#build-your-preference-center.
  • Check that the Callout components render properly with their JSX text props containing inline <a> and <code> elements.
  • Bugbot flagged 1 potential issue in its review — worth checking that finding before merge.
Open in Web View Automation 

Sent by Cursor Automation: Docs PR classifier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant