feat(KNO-13529): Docs for Knock hosted preference center (w/o custom domains)#1474
feat(KNO-13529): Docs for Knock hosted preference center (w/o custom domains)#1474andy-knock wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| <code>false</code>, the notification won't be delivered. See{" "} | ||
| <a href="/preferences/overview#preference-evaluation-rules"> | ||
| preference evaluation rules | ||
| </a>{" "} |
There was a problem hiding this comment.
Duplicate preference evaluation links
Low Severity
preference evaluation and preference evaluation rules both link to /preferences/overview#preference-evaluation-rules on the same page. Only the first mention should stay linked.
Additional Locations (1)
Triggered by learned rule: Link Knock concepts on first mention only per page
Reviewed by Cursor Bugbot for commit 79b2b1d. Configure here.
79b2b1d to
245b33e
Compare
245b33e to
aafe2de
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit aafe2de. Configure here.
| <Callout | ||
| type="info" | ||
| title="Users only." | ||
| text="The hosted preference center currently supports user recipients only. It doesn't support managing preferences for objects or tenants." |
There was a problem hiding this comment.
Missing tenants objects first links
Low Severity
The “Users only” callout’s first mention of objects and tenants is plain text. Knock concept terms should link to their concept pages on first mention only (e.g. /concepts/objects, /concepts/tenants).
Triggered by learned rule: Link Knock concepts on first mention only per page
Reviewed by Cursor Bugbot for commit aafe2de. Configure here.
There was a problem hiding this comment.
Risk MEDIUM: Adds new documentation page for Knock's hosted preference center with sidebar navigation changes and updates to the existing preferences overview page.
Reasons
- A new MDX page was added (
content/preferences/hosted-preference-center.mdxwith 137 lines), which triggers MEDIUM per the new-page rule. - The sidebar navigation file
data/sidebars/platformSidebar.tswas modified to include the new page entry, which triggers MEDIUM per the sidebar-change rule. - The diff is content-focused with no component, layout, style, or build configuration changes, so no HIGH triggers apply.
- All changes are scoped to a single documentation section (
content/preferences/), so cross-section risk does not apply. - Total diff is 158 additions and 2 deletions across 3 files — moderate scope with no destructive changes.
Notes
- Verify the new sidebar entry renders correctly and the page appears in the expected position under the Preferences section (between "Overview" and "Object preferences").
- Confirm all internal links in the new page resolve correctly, especially
/preferences/overview#how-preferences-work,/preferences/overview#preference-evaluation-rules,/preferences/overview#merging-preferences,/preferences/commercial-unsubscribe,/template-editor/branding,/integrations/email/layouts, and/preferences/overview#build-your-preference-center. - Check that the Callout components render properly with their JSX
textprops containing inline<a>and<code>elements. - Bugbot flagged 1 potential issue in its review — worth checking that finding before merge.
Sent by Cursor Automation: Docs PR classifier





Uh oh!
There was an error while loading. Please reload this page.