Skip to content

fix: change MessageEmailContent from field from String to union type #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zerocool4u2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: change MessageEmailContent from field from String to union type #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 43 additions & 4 deletions lib/knockapi/models/message_get_content_response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,11 @@ class MessageEmailContent < Knockapi::Internal::Type::BaseModel
required :_typename, String, api_name: :__typename

# @!attribute from
# The sender's email address.
# The sender's email address. Can be a string email address or an object
Copy link
Copy Markdown
Contributor

@meryldakin meryldakin Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we want a "." at the end of this sentence

Copy link
Copy Markdown
Author

@zerocool4u2 zerocool4u2 Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has the . on the next line

# with email and name fields.
#
# @return [String]
required :from, String
# @return [String, Knockapi::Models::MessageGetContentResponse::Data::MessageEmailContent::From]
required :from, union: -> { Knockapi::Models::MessageGetContentResponse::Data::MessageEmailContent::From }

# @!attribute html_body
# The HTML body of the email message.
Expand Down Expand Up @@ -120,7 +121,7 @@ class MessageEmailContent < Knockapi::Internal::Type::BaseModel
#
# @param _typename [String] The typename of the schema.
#
# @param from [String] The sender's email address.
# @param from [String, Knockapi::Models::MessageGetContentResponse::Data::MessageEmailContent::From::EmailObject] The sender's email address. Can be a string or an object with email and name fields.
#
# @param html_body [String] The HTML body of the email message.
#
Expand All @@ -135,6 +136,44 @@ class MessageEmailContent < Knockapi::Internal::Type::BaseModel
# @param cc [String, nil] The CC email addresses.
#
# @param reply_to [String, nil] The reply-to email address.

# The sender's email address. Can be a string email address or an object
# with email and name fields.
#
# @see Knockapi::Models::MessageGetContentResponse::Data::MessageEmailContent#from
module From
extend Knockapi::Internal::Type::Union

# A simple string email address.
variant String

# An object with email and name fields.
variant -> { Knockapi::Models::MessageGetContentResponse::Data::MessageEmailContent::From::EmailObject }

class EmailObject < Knockapi::Internal::Type::BaseModel
# @!attribute email
# The sender's email address.
#
# @return [String]
required :email, String

# @!attribute name
# The sender's display name.
#
# @return [String, nil]
optional :name, String, nil?: true

# @!method initialize(email:, name: nil)
# The sender's email address as an object.
#
# @param email [String] The sender's email address.
#
# @param name [String, nil] The sender's display name.
end

# @!method self.variants
# @return [Array(String, Knockapi::Models::MessageGetContentResponse::Data::MessageEmailContent::From::EmailObject)]
end
end

class MessageSMSContent < Knockapi::Internal::Type::BaseModel
Expand Down