Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/guard-empty-layer-stack.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@kobalte/core': patch
---

fix(dismissable-layer): guard `isTopMostLayer` against an empty layer stack.

When the dismissable-layer stack is empty (e.g. callbacks fired after the last layer has already been removed during teardown), `layers[layers.length - 1]` is `undefined` and reading `.node` on it throws `TypeError: Cannot read properties of undefined (reading 'node')`. Returning `false` early when there are no layers makes the predicate behave consistently with "no top-most layer is currently registered".
2 changes: 1 addition & 1 deletion packages/core/src/dismissable-layer/layer-stack.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function find(node: HTMLElement | undefined): LayerModel | undefined {
}

function isTopMostLayer(node: HTMLElement | null) {
return layers[layers.length - 1].node === node;
return layers.length > 0 && layers[layers.length - 1].node === node;
}

function getPointerBlockingLayers() {
Expand Down