Skip to content

Add roadmap progress tracker and completion UI#211

Merged
komalharshita merged 7 commits into
komalharshita:mainfrom
somu0571:feature/roadmap-progress
Jun 3, 2026
Merged

Add roadmap progress tracker and completion UI#211
komalharshita merged 7 commits into
komalharshita:mainfrom
somu0571:feature/roadmap-progress

Conversation

@somu0571
Copy link
Copy Markdown
Contributor

@somu0571 somu0571 commented May 17, 2026

Summary

This PR improves the Project Roadmap section by adding interactive progress tracking. Users can now mark roadmap steps as completed using checkboxes and track their overall progress with a dynamic progress bar and completion percentage. The update makes project roadmaps more engaging and helps users visually follow their progress & it's stored using browser's local storage, that restore the checkboxes after every refresh

Related Issue

Closes #183

Type of Change

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed

File Change made
templates/project.html Updated roadmap structure and added checkbox support with progress UI
static/style.css Added roadmap progress bar styling, completion states, checkbox styling, and layout improvements
static/script.js Added roadmap progress tracking logic and completion percentage calculation

How to Test This PR

  1. Checkout this branch:
git checkout feature/roadmap-progress
  1. Install dependencies:
pip install -r requirements.txt
  1. Run the application:
python app.py
  1. Open:
http://127.0.0.1:5000
  1. Navigate to any project detail page.

  2. Under the Project Roadmap section:

  • Check roadmap steps
  • Verify completed items visually update
  • Verify progress bar updates instantly
  • Verify completion percentage changes correctly
  1. Test on desktop layout & mobile layout

Expected:

  • Progress updates in real time
  • Completed steps show completion styling
  • Progress bar fills correctly
  • Local storage & restoration working properly

Test Results

UI tested locally

✓ Roadmap checkboxes working
✓ Progress updates correctly
✓ Responsive layout verified

Screenshots for Deskstop & Mobile View

Screenshot 2026-05-17 115840 Screenshot 2026-05-17 200603
Before After
Roadmap without progress tracking Roadmap with checkbox tracking and progress bar

Self-Review Checklist

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
  • I have run python tests/test_basic.py and all tests pass
  • I have run flake8 . locally and there are no errors
  • I have not introduced any print() or console.log() debug statements
  • I have not modified files outside the scope of the linked issue
  • I tested the UI on desktop layouts
  • If I added project data, all required fields are included

Notes for Reviewer

This PR focuses only on roadmap interaction and UI enhancements. No backend logic or recommendation functionality was modified.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 17, 2026

@somu0571 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

Copy link
Copy Markdown
Owner

@komalharshita komalharshita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the detailed feature implementation. This is a meaningful UX enhancement and the roadmap interaction/progress UI has been implemented thoughtfully overall.

I reviewed the changes carefully and there are a few important improvements needed before merge:

  1. The PR description mentions that roadmap progress is stored using browser local storage, but the current implementation does not include any localStorage persistence logic. At the moment, progress resets after page refresh. Please either:
  • implement proper localStorage persistence and restoration,
    OR
  • remove the persistence claim from the PR description.
  1. Since this introduces an interactive progress tracker, accessibility semantics should also be improved. Please consider adding:
  • proper role="progressbar"
  • aria-valuenow, aria-valuemin, and aria-valuemax
  • accessible labeling for progress updates.
  1. Please upload mobile screenshots/testing evidence as this PR changes roadmap layout structure, checkbox alignment, and progress bar responsiveness. The current progress bar uses a fixed min-width: 300px, which may overflow on smaller devices.

  2. The .gitignore modification appears unrelated to the roadmap feature. Please either explain why it is necessary or remove unrelated changes from the PR.

Once these improvements are addressed, this will be in a much stronger state for approval.

@somu0571 somu0571 requested a review from komalharshita May 17, 2026 16:04
somu0571

This comment was marked as duplicate.

Copy link
Copy Markdown
Contributor Author

@somu0571 somu0571 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@komalharshita

Thanks for the detailed review and suggestions.

I’ve now addressed the requested improvements:

  • Added localStorage persistence for roadmap progress tracking and restoration after page refresh.

  • Improved accessibility by adding:

    • role="progressbar"
    • aria-valuenow
    • aria-valuemin
    • aria-valuemax
    • aria-live
  • Removed the fixed width issue affecting responsiveness on smaller devices.

  • Tested the updated roadmap layout on mobile view and uploaded screenshots.

  • Removed the unrelated .gitignore modification from the PR scope.

Screenshot for mobile view
Screenshot 2026-05-17 200603

Thanks again for the feedback.

@komalharshita
Copy link
Copy Markdown
Owner

@somu0571 please resolve the merge conflicts

@komalharshita komalharshita added the need review Further information is requested label May 24, 2026
@somu0571
Copy link
Copy Markdown
Contributor Author

somu0571 commented May 24, 2026

Updated & resolved the conflicts pls proceed without any delay ma'am , if any issue do let me know
Thanks

@somu0571
Copy link
Copy Markdown
Contributor Author

@komalharshita , after so much remainders , you have not checked my pr #211 this very unprofessional behaviour from your side
you are responding to those who have pr's in last 2-3 days ago, Kindly revisit #211 & merge it without any delay

Copy link
Copy Markdown
Owner

@komalharshita komalharshita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@somu0571

Please keep communication respectful and professional.

This PR has not been ignored. The review history shows that:

  • A detailed review was provided with multiple requested changes.
  • Additional accessibility and persistence concerns were identified.
  • Merge conflicts were later reported and needed to be resolved before further review.

As maintainers, we are reviewing and managing a large number of issues and pull requests simultaneously. Reviews are handled based on project workload, contributor responses, merge readiness, and overall repository priorities. A delay in review does not imply that a PR has been overlooked.

Regarding the PR itself, I am performing another review now. Please note that merge conflicts, requested changes, failing checks, and additional review findings can all affect review timelines.

Future comments should focus on the technical status of the PR rather than personal remarks about maintainers or other contributors.

Thank you for your contribution.

@komalharshita
Copy link
Copy Markdown
Owner

Required Changes

1. localStorage persistence is not project-specific

The current implementation stores roadmap progress using a single global key:

"devpath-roadmap-progress"

This means roadmap progress from one project can overwrite or affect progress on another project. Since DevPath contains multiple project detail pages, progress tracking should be scoped to the specific project being viewed.

Please update the implementation to use a unique project-based storage key (for example, based on project ID or slug) so that each project's roadmap progress is stored independently.

Additional Notes

  • The feature itself is a useful UX enhancement.
  • Accessibility improvements and progress bar semantics have been added correctly.
  • Merge conflicts have been resolved.

However, the storage implementation currently introduces incorrect behavior across multiple projects, so I cannot approve the PR in its current state.

Please address the localStorage scoping issue and request another review once updated.

Requesting changes until the storage issue is resolved.

@somu0571
Copy link
Copy Markdown
Contributor Author

somu0571 commented Jun 2, 2026

@komalharshita Thanks for the review. I've updated the roadmap persistence to use a project-specific localStorage key based on PROJECT_ID, ensuring roadmap progress is stored independently for each project detail page. I tested across multiple projects and confirmed that progress no longer carries over between projects. Requesting another review.

@somu0571 somu0571 requested a review from komalharshita June 2, 2026 16:30
@somu0571
Copy link
Copy Markdown
Contributor Author

somu0571 commented Jun 2, 2026

@komalharshita sorry for my rude behaviour, but you were not active since 4 - 5 days , & there is no way to contact you regarding this PR.

@komalharshita
Copy link
Copy Markdown
Owner

Approved for merge!

@komalharshita komalharshita merged commit 0481594 into komalharshita:main Jun 3, 2026
7 of 8 checks passed
@komalharshita komalharshita removed the need review Further information is requested label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add interactive step-by-step roadmap checklist with localStorage persistence

2 participants