Improve portfolio interactivity, responsiveness and add dark mode support#292
Conversation
Updated template rendering section to clarify Jinja2 usage.
|
@Smrithikrishna123 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Smrithi-krishna ensure that all checks pass |
|
@komalharshita All checks are passing now |
|
Hello @komalharshita, could you please review my PR?. All tests are now passing. |
|
hi @komalharshita ,mam can you please check when you have time |
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for the contribution — there are several good improvements here, especially the mobile nav behavior, scroll reveal implementation, form validation structure, and theme persistence logic.
However, this PR needs cleanup before it can be merged.
Main issues to address:
- Do not replace template placeholders with personal/demo content (
YK,[YOUR NAME], custom descriptions, etc.). This repository is a starter template and those placeholders should remain generic. - Please restore the educational TODO comments/instructions that were removed throughout the file. They are important for beginner contributors using this project as a learning resource.
- The navbar currently contains an invalid HTML structure (
<li>outside a<ul>). - Improve accessibility for the dark mode toggle (
aria-label, accessible semantics, focus states). - Dark mode styling needs a more complete contrast/accessibility pass across all sections.
- The PR scope is too broad. Try to keep unrelated cleanup/template edits separate from feature work.
There is good work here overall, but the PR needs refinement and cleaner scoping before approval.
|
Thank you for the detailed review and feedback. I understand the concerns raised. |
|
hi @komalharshita ,can you please check it now |
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for the updates and for addressing several of the requested changes.
The functionality additions (theme persistence, navigation highlighting, scroll reveal, skill bar animation, and form validation) are appreciated and generally look good.
However, I cannot approve this PR yet because some previously requested issues remain unresolved:
• The navbar still contains invalid HTML (<li> is placed outside of a <ul>).
• The dark mode toggle lacks accessibility improvements (aria-label, accessible state indication, etc.).
• Template placeholders/content were modified unnecessarily ([Your Name], [Your Title], etc.) and should remain consistent with the starter template.
• Dark mode styling still needs a more complete accessibility/contrast review.
• The PR scope remains quite broad and mixes feature work with unrelated template/formatting changes.
Please address these points and update the PR for another review.
Thank you for the contribution.
|
@Smrithi-krishna ping me when you're done |
|
Hey @komalharshita! Just letting you know I'm all done. I've gone ahead and addressed all your comments, so could you please take a look and let me know if anything else is needed? Thanks!
|


Summary [required]
This PR enhances the portfolio website by completing missing JavaScript functionality and improving overall interactivity, responsiveness, and user experience.
It implements key UI/UX features including navigation improvements, scroll-based interactions, form validation, and theme switching.
Related Issue [required]
Closes #171
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
portfolio.html.nojekyllHow to Test This PR [required]
git checkout your-branch-namepip install -r requirements.txtpython app.pypython tests/test_basic.pyExpected test output:
Test Results [required]
Screenshots (if UI change)
|


Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
This PR focuses on improving interactivity, responsiveness, and user experience of the portfolio website. Please let me know if any improvements or changes are required.