Added Contact Us page with navigation links and responsive UI#354
Added Contact Us page with navigation links and responsive UI#354Suhas334 wants to merge 3 commits into
Conversation
|
@Suhas334 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for the contribution. The Contact page is well designed, responsive, and integrates nicely into the navigation structure. I also appreciate that links were added to both the navbar and footer, making the page easier to discover.
Before merge, I would like a few improvements:
- Move the large inline <style> block into the project's shared stylesheet structure instead of keeping page-specific CSS inside the template.
- Align the Contact page with the existing site layout/components so future navbar, footer, and theme updates remain consistent across pages.
- Review dark-mode compatibility. Several recent PRs introduced dark-mode support, and the current page uses many hardcoded light-theme colors that may not adapt correctly.
- Add rel="noopener noreferrer" to external links that use target="_blank".
- Resolve the current merge conflicts with the latest main branch.
Once these items are addressed and conflicts are resolved, I'd be happy to re-review. The feature itself is useful and the UI direction looks good.
|
hi @komalharshita I made changes according to your instruction.you can check now and review it. |
komalharshita
left a comment
There was a problem hiding this comment.
Thank you for the contribution. I reviewed the updated implementation and found several issues that still need to be addressed before this PR can be merged:
- The Contact page duplicates large sections of existing navigation and footer markup instead of reusing shared layouts/components, which increases maintenance overhead.
- The PR includes unrelated modifications in existing files (especially
main_routes.py) that are not directly required for adding a Contact page. - The Contact page mostly redirects users to GitHub links and issue pages rather than providing actual contact information or a meaningful contact workflow.
- A large amount of inline styling and duplicated theme-toggle/navigation code has been introduced, making the page harder to maintain.
- The new page should follow the project's existing layout patterns and avoid copying entire navigation/footer structures into a standalone template.
Please refactor the implementation to minimize duplication, remove unrelated changes, and ensure the Contact page provides clear project-specific contact functionality before requesting another review.
Summary [required]
This PR adds a dedicated Contact Us page to improve communication and accessibility for users and contributors. A new Contact link has been added to both the navbar and footer for easier navigation. The Contact Us page includes GitHub and issue-reporting links with a responsive and modern UI design that matches the existing DevPath website style.
Related Issue [required]
Closes #issue_number
Type of Change [required]
[x] Feature — adds new functionality
[x] Style — CSS or visual changes only, no logic change
What Was Changed [required]
templates/index.html
templates/contact.html
routes/main_routes.py
/contactrouteHow to Test This PR [required]
Clone this branch:
git checkout feat/contact-us-page
Install dependencies:
pip install -r requirements.txt
Run the app:
python app.py
Open:
http://127.0.0.1:5000/
Verify:
Test Results [required]
Application tested successfully.
No Flask or console errors found.
Responsive UI verified on desktop and mobile screens.
Screenshots ( UI changed)
Before:
No Contact Us page available
After:
Added responsive Contact Us page with navigation links
Self-Review Checklist [required]
[x] I have read CONTRIBUTING.md and followed all guidelines
[x] My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
[x] I have run python tests/test_basic.py and all tests pass
[x] I have run flake8 . locally and there are no errors
[x] I have not introduced any print() or console.log() debug statements
[x] Every new function I wrote has a docstring
[x] I have not modified files outside the scope of the linked issue
[x] If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
Notes for Reviewer
Added a modern responsive Contact Us page with integrated navigation links and consistent UI styling.