Skip to content

[Feat]: Add persistent dark theme toggle with localStorage state caching#441

Closed
Siddh2024 wants to merge 3 commits into
komalharshita:mainfrom
Siddh2024:feat-devpath-darkmode2
Closed

[Feat]: Add persistent dark theme toggle with localStorage state caching#441
Siddh2024 wants to merge 3 commits into
komalharshita:mainfrom
Siddh2024:feat-devpath-darkmode2

Conversation

@Siddh2024
Copy link
Copy Markdown
Contributor

Description

This Pull Request introduces a native, state-persistent Dark Theme option to the Devpath platform. This enhancement improves visual accessibility and comfort during low-light operation while strictly preserving the repository's original global typography and structural core components.

Proposed Changes

  • Structural Theme Switcher: Integrated an intuitive, accessible theme toggle element featuring sharp inline SVG icons into the main navigation layout.
  • Semantic Styling Variables: Refactored hardcoded interface colors into dynamic CSS variables (--bg-primary, --text-main, --card-bg) supporting smooth runtime transitions.
  • State Persistence Caching: Implemented browser client-side localStorage hook mechanisms to ensure the user's theme selection remains intact across page refreshes and subsequent sessions.

Related Issue

Closes #318

Verification Checklist

  • Verified seamless runtime theme swapping without visual layout shifts.
  • Confirmed selected theme state persists correctly using browser inspector caching tools.
  • Audited typography contrast levels across all layout blocks to ensure optimal accessibility.
Screenshot 2026-05-19 150437 Screenshot 2026-05-19 150510 Screenshot 2026-05-19 150531

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@Siddh2024 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Siddh2024
Copy link
Copy Markdown
Contributor Author

@komalharshita , please approve this pr ma'am.

@Siddh2024
Copy link
Copy Markdown
Contributor Author

@komalharshita , I have resolved the conflicts.

@komalharshita komalharshita added duplicate This issue or pull request already exists and removed type:accessibility ui labels Jun 2, 2026
@komalharshita
Copy link
Copy Markdown
Owner

Thank you for the contribution.

After reviewing this PR, I am unable to proceed with approval.

The repository already has multiple active and overlapping dark mode implementations, and this PR introduces another large-scale dark theme system affecting several templates, JavaScript, and styling files.

Additionally, the PR currently contains merge conflicts and unresolved conflict markers, which prevent it from being reviewed or merged safely.

Given the overlap with existing dark mode work and the significant scope of the changes (+800 lines across multiple files), we are not moving forward with this implementation.

I encourage you to pick another open issue that is not currently being addressed by multiple active submissions.

Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists gssoc-2026

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add persistent Dark Mode support to the DevPath platform.

2 participants