Skip to content

Fix project recommendation form submission and results rendering#685

Open
Khushi-dev-0706 wants to merge 1 commit into
komalharshita:mainfrom
Khushi-dev-0706:fix-scriptjs-form-rendering
Open

Fix project recommendation form submission and results rendering#685
Khushi-dev-0706 wants to merge 1 commit into
komalharshita:mainfrom
Khushi-dev-0706:fix-scriptjs-form-rendering

Conversation

@Khushi-dev-0706
Copy link
Copy Markdown

@Khushi-dev-0706 Khushi-dev-0706 commented May 29, 2026

Summary

This PR fixes the frontend recommendation form which was broken due to JavaScript syntax errors in static/script.js.

The issue prevented project recommendations from being fetched and rendered correctly. After the fix, users can successfully submit the recommendation form, receive project recommendations, view dynamically rendered project cards, handle empty states, and navigate to project details.

Related Issue

Closes #672

Type of Change

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed

File Change made
static/script.js Fixed JavaScript syntax errors and restored recommendation form submission, API fetching, project rendering, empty-state handling, and project navigation

How to Test This PR

  1. Clone the branch and install dependencies.
  2. Run the application: python app.py
  3. Open: http://127.0.0.1:5000
  4. Fill the recommendation form.
  5. Click "Start Finding Projects".
  6. Verify that:
    • Recommendations are fetched successfully.
    • Project cards are displayed.
    • Empty-state handling works correctly.
    • Project detail navigation works correctly.

Test Results

Manual testing completed successfully.

Verified:

  • Recommendation fetching
  • Dynamic project rendering
  • Empty-state handling
  • Project navigation

Self-Review Checklist

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
  • I have run python tests/test_basic.py and all 27 tests pass
  • I have run flake8 . locally and there are no errors
  • I have not introduced any print() or console.log() debug statements
  • Every new function I wrote has a docstring
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
  • If I added a project to the dataset, it has all required JSON fields

Notes for Reviewer

The issue was caused by JavaScript syntax errors in static/script.js, which prevented the recommendation workflow from executing. The fix has been manually tested and verified locally.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

@Khushi-dev-0706 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Frontend form completely broken due to syntax errors in script.js

1 participant