fix: resolve syntax issues in recommendation flow#714
Open
nirvani-nj wants to merge 1 commit into
Open
Conversation
|
@nirvani-nj is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary [required]
This PR fixes multiple syntax issues in
static/script.jsthat were breaking the recommendation flow on the homepage.The malformed JavaScript prevented the file from parsing completely, which caused skill chip input, autocomplete suggestions, quick-pick interactions, and recommendation form submission to stop working. The PR cleans up the broken submit handler and fixes the malformed
renderResults()logic to restore normal frontend behaviour.Related Issue [required]
Related to frontend recommendation flow fixes discovered while working on #324
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
static/script.jsrenderResults()implementationHow to Test This PR [required]
Clone this branch:
Install dependencies:
Run the app:
Open:
Test the homepage flow:
Confirm recommendations render successfully without console syntax errors.
Test Results [required]
Screenshots (if UI change)
N/A — no UI changes were introduced.
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
This PR focuses only on restoring valid frontend functionality after malformed merge conflicts introduced duplicated conditionals and incomplete closures inside
static/script.js.