Skip to content

Support newer v5 nickel usb gadget name kobo#7

Open
NerdyProjects wants to merge 6 commits into
koreader:masterfrom
NerdyProjects:v5_gadget_kobo
Open

Support newer v5 nickel usb gadget name kobo#7
NerdyProjects wants to merge 6 commits into
koreader:masterfrom
NerdyProjects:v5_gadget_kobo

Conversation

@NerdyProjects

@NerdyProjects NerdyProjects commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

More recent v5 firmware renamed the usb_gadget from g1 to kobo. accept this in USBMS.

  • handle new usb_gadget handling for nickel support
  • handle swapfile on /mnt/onboard

This change is Reviewable

@NerdyProjects NerdyProjects marked this pull request as draft March 6, 2026 10:48
@NerdyProjects

Copy link
Copy Markdown
Contributor Author

original firmware does swapoff -a before unmounting /mnt/onboard now, that does the trick.

I am duplicating infos between here and koreader/koreader#12401

@Frenzie Frenzie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, but of course this is @NiLuJe's thing.

@NerdyProjects

Copy link
Copy Markdown
Contributor Author

@NiLuJe this works now.

Original firmware has a new /etc/init.d/usb-gadget (attached as usb-gadget.sh)
usb-gadget.sh

It might be that we don't need to fiddle with usb gadget config at all now, but i went the safe way keeping existing reconfiguration and restoring to nickel-defaults.

What do you say?

@NerdyProjects NerdyProjects marked this pull request as ready for review March 6, 2026 14:31

@NiLuJe NiLuJe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions, a few minor style nits, but the only real issue I can see is with the stock script call ;).

Comment thread scripts/end-usbms.sh
Comment thread scripts/end-usbms.sh
Comment thread scripts/end-usbms.sh Outdated
@NiLuJe

NiLuJe commented Mar 7, 2026

Copy link
Copy Markdown
Member

What do you say?

We have a long & fun history with the stock Nickel USBMS doing weird and broken things, so, yeah, I'd rather avoid it, even if it is much saner than it used to ;).

@NerdyProjects NerdyProjects requested a review from NiLuJe March 7, 2026 06:00
@NerdyProjects

Copy link
Copy Markdown
Contributor Author

What do you say?

We have a long & fun history with the stock Nickel USBMS doing weird and broken things, so, yeah, I'd rather avoid it, even if it is much saner than it used to ;).

Sorry I didn't understand: What exactly to avoid? Like: Is there something I should change from this state?

@NiLuJe

NiLuJe commented Mar 7, 2026

Copy link
Copy Markdown
Member

What do you say?

We have a long & fun history with the stock Nickel USBMS doing weird and broken things, so, yeah, I'd rather avoid it, even if it is much saner than it used to ;).

Sorry I didn't understand: What exactly to avoid? Like: Is there something I should change from this state?

Yeah, sorry, not enough context in my answer ;).


Given the latest inline discussion, that's fine, I'd just add the comment about Nickel's new expectations of the gadget being setup.

@NerdyProjects

Copy link
Copy Markdown
Contributor Author

I did that, so that should be good to go :-)

@NerdyProjects

Copy link
Copy Markdown
Contributor Author

Let me ping you @NiLuJe again as you asked so :D Anything more I should change before this is good to go?

@NiLuJe

NiLuJe commented Mar 20, 2026

Copy link
Copy Markdown
Member

No, this looks pretty good, sorry ;).

I'm just under a couple of deadlines right now, I should be able to button this up next week-end or so ;)

@NerdyProjects

Copy link
Copy Markdown
Contributor Author

Should I ping you regurlarly @NiLuJe or is it stressing? :)

@NiLuJe

NiLuJe commented Apr 20, 2026

Copy link
Copy Markdown
Member

Nope, good idea, this had completely skipped my mind ;p.

I should have more time in a couple of weeks, FWIW, sorry about that ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants