Make porch-server manager-runnable - #1111
Open
mozesl-nokia wants to merge 13 commits into
Open
Conversation
Assisted-by: Cursor:composer-2.5 Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
mozesl-nokia
requested review from
efiacor,
kispaljr and
liamfallon
as code owners
July 10, 2026 11:19
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
Bot
added
the
size:L
mozesl-nokia
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors porch-server startup so the apiserver runs as a manager.Runnable under a controller-runtime manager, enabling future HA via leader election while keeping existing server behavior largely intact.
Changes:
- Wrap porch apiserver startup in a
manager.Runnable(PorchServer) and start it via a controller-runtime manager. - Add HA/leader-election CLI flags and a probe-port option for manager health/ready endpoints.
- Update unit/e2e tests to cover new flag parsing and (some) manager health delegation behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/api/advanced_test.go | Makes readiness gate assertions order-insensitive (ElementsMatch). |
| pkg/cmd/server/start.go | Switches startup to manager-based lifecycle; adds probe/HA flags and health delegation helpers. |
| pkg/cmd/server/start_test.go | Adds coverage for new HA/probe flags and standby readiness behavior. |
| pkg/apiserver/porchserver.go | Introduces PorchServer implementing manager.Runnable + LeaderElectionRunnable. |
| pkg/apiserver/config.go | Builds controller-runtime manager, registers controllers, and returns (mgr, porchServer) instead of a standalone server. |
| pkg/apiserver/apiserver_test.go | Adds tests for kubeconfig loading, client construction, New, and HA helpers. |
| go.mod | Moves sigs.k8s.io/cli-utils to indirect dependency. |
Signed-off-by: mozesl-nokia <laszlo.mozes@nokia.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: mozesl-nokia <laszlo.mozes@nokia.com>
Assisted-by: Cursor:composer-2.5 Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Contributor
Author
|
The rest of the coverage would probably require envtest, which I'm not familiar with (and would not trust AI with). This was not covered previously either. The security rating is for internal network comms, so false positive. |
8 tasks
rendre-greyling
previously approved these changes
Jul 20, 2026
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
rendre-greyling
previously approved these changes
Jul 21, 2026
Contributor
I know most of the uncovered is config but could we refactor some of it out to helpers and test in isolation? |
Assisted-by: Cursor:grok-4.5 Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Assisted-by: Cursor:grok-4.5 Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
dosubot
Bot
added
size:XL
Assisted-by: Cursor:grok-4.5 Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Assisted-by: Cursor:grok-4.5 Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make porch-server manager-runnable
Description
Related Issue(s)
Type of Change
Checklist
Additional Notes (Optional)
AI Disclosure
If so, please describe how: