Fixed CLI Compatibility Matrix runs - #1128
Conversation
…erver vs ctl in its own section for cleaner dev debug Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
… if successful Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
There was a problem hiding this comment.
Pull request overview
Updates the scheduled “CLI Compatibility Matrix” GitHub Actions workflow to run a smaller, more reliable compatibility matrix by selecting only stable semver releases, testing against main for “latest”, and producing more isolated per-CLI logs/results for easier debugging.
Changes:
- Filter upstream releases to stable
vX.Y.Ztags and reduce the server matrix tolatest + 2recent releases. - Switch “latest” server checkout to
main(instead of the1.5branch). - Split the CLI E2E runs into separate steps (latest, n-1, n-2) with per-run logs and JSON result files.
Comments suppressed due to low confidence (2)
.github/workflows/porch-compat-matrix.yaml:228
- The regex used to extract failing tests uses
\swithgrep -E, but\sis not portable in POSIX ERE and won’t match whitespace on many systems (it typically matches a literals). This can causefailed_teststo be empty even when tests fail. Use a POSIX character class instead.
FAILED_TESTS=$(grep -E '^\s*--- FAIL:' "${LOG_FILE}" | sed 's/.*--- FAIL: //' | sed 's/ (.*//' | tr '\n' ',' | sed 's/,$//')
.github/workflows/porch-compat-matrix.yaml:261
- The regex used to extract failing tests uses
\swithgrep -E, but\sis not portable in POSIX ERE and won’t match whitespace on many systems (it typically matches a literals). This can causefailed_teststo be empty even when tests fail. Use a POSIX character class instead.
FAILED_TESTS=$(grep -E '^\s*--- FAIL:' "${LOG_FILE}" | sed 's/.*--- FAIL: //' | sed 's/ (.*//' | tr '\n' ',' | sed 's/,$//')
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
mozesl-nokia
left a comment
There was a problem hiding this comment.
I think the inlined scripts in the run blocks should be extracted the sh files. Since there is a lot of duplicate stuff in there, probably one parameterized script will do.
yes exactly. these were previously all in a for loop to not duplicate but i needed to break that to have them run under a separate name so they can be viewed and debugged independently. Ill see if i can do them in a separate script and call that. Good Suggestion |
…tion Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
…hose versions or current latest Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
|
|
hey @mozesl-nokia i believe this script should work in the job to remove the duplicated code but i cannot test it until it is merged. |





Fixed CLI Compatibility Matrix runs
Description
Related Issue(s)
Type of Change
Checklist
Testing Instructions (Optional)
Additional Notes (Optional)
AI Disclosure